From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14688 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] mips: add single-instruction math functions Date: Wed, 18 Sep 2019 09:49:13 -0400 Message-ID: <20190918134913.GZ9017@brightrain.aerifal.cx> References: <20190911103224.504A15C44C@mx7.valuehost.ru> <20190913183123.GI9017@brightrain.aerifal.cx> <836025754.20190918160733@mobile-stream.com> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="26712"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14704-gllmg-musl=m.gmane.org@lists.openwall.com Wed Sep 18 15:49:32 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1iAaKn-0006je-Al for gllmg-musl@m.gmane.org; Wed, 18 Sep 2019 15:49:29 +0200 Original-Received: (qmail 14331 invoked by uid 550); 18 Sep 2019 13:49:26 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 14313 invoked from network); 18 Sep 2019 13:49:25 -0000 Content-Disposition: inline In-Reply-To: <836025754.20190918160733@mobile-stream.com> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:14688 Archived-At: On Wed, Sep 18, 2019 at 04:07:33PM +0300, info@mobile-stream.com wrote: > >> diff --git a/src/math/mips/fabs.c b/src/math/mips/fabs.c > >> new file mode 100644 > >> index 00000000..0a5aa3b1 > >> --- /dev/null > >> +++ b/src/math/mips/fabs.c > >> @@ -0,0 +1,16 @@ > >> +#if !defined(__mips_soft_float) && defined(__mips_abs2008) > > R> Why is this dependent on __mips_abs2008? > > > ABS.fmt is non-arithmetic only on cores with the corresponding FCSR > bit hardwired to 1. It is R6 (always) and some R5 cores (such as > P5600, M5150). OK, in that case it may be okay to condition it on R6 (which is a different ISA/ABI), as long as that's actually a hard requirement of the R6 ISA. Rich