From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14750 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] remove remaining traces of __tls_get_new Date: Sun, 29 Sep 2019 16:56:39 -0400 Message-ID: <20190929205639.GK9017@brightrain.aerifal.cx> References: <20190929130527.GR22009@port70.net> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="159037"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14766-gllmg-musl=m.gmane.org@lists.openwall.com Sun Sep 29 22:56:56 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1iEgFT-000fCa-El for gllmg-musl@m.gmane.org; Sun, 29 Sep 2019 22:56:55 +0200 Original-Received: (qmail 3520 invoked by uid 550); 29 Sep 2019 20:56:52 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 3502 invoked from network); 29 Sep 2019 20:56:52 -0000 Content-Disposition: inline In-Reply-To: <20190929130527.GR22009@port70.net> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:14750 Archived-At: On Sun, Sep 29, 2019 at 03:05:27PM +0200, Szabolcs Nagy wrote: > reported on irc by malc_ > >From 4a7090ab76d81b59f57a83bce9d22582e35a8b2b Mon Sep 17 00:00:00 2001 > From: Szabolcs Nagy > Date: Sun, 29 Sep 2019 12:25:39 +0000 > Subject: [PATCH] remove remaining traces of __tls_get_new > > Some declarations of __tls_get_new were left in the code, even > though the definition got removed in > > commit 9d44b6460ab603487dab4d916342d9ba4467e6b9 > install dynamic tls synchronously at dlopen, streamline access > > this can make the build fail with > > ld: lib/libc.so: hidden symbol `__tls_get_new' isn't defined > > when libc.so is linked without --gc-sections, because a .hidden > declaration in asm code creates a reference even if the symbol > is not actually used. This is definitely a tooling bug. There is no reference to the symbol, only declarations of it. I think it's a good idea to cleanup the spurious mentions of it anyway, though. Rich