From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14830 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Use fabsl instead of fabs on long double operand in floatscan.c Date: Fri, 18 Oct 2019 21:19:58 -0400 Message-ID: <20191019011958.GA16318@brightrain.aerifal.cx> References: <20191018144909.GN7832@port70.net> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="92280"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14846-gllmg-musl=m.gmane.org@lists.openwall.com Sat Oct 19 03:20:15 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1iLdPg-000NpU-U2 for gllmg-musl@m.gmane.org; Sat, 19 Oct 2019 03:20:13 +0200 Original-Received: (qmail 21754 invoked by uid 550); 19 Oct 2019 01:20:10 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 21736 invoked from network); 19 Oct 2019 01:20:10 -0000 Content-Disposition: inline In-Reply-To: <20191018144909.GN7832@port70.net> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:14830 Archived-At: On Fri, Oct 18, 2019 at 04:49:09PM +0200, Szabolcs Nagy wrote: > * Dan Gohman [2019-10-18 07:02:11 -0700]: > > This fixes a compiler warning with clang: > > > > floatscan.c:304:13: warning: absolute value function 'fabs' given an > > argument of type 'long double' but has parameter of type 'double' which may > > cause truncation of value [-Wabsolute-value]. > > > > This does change the behavior of the expression because the value is no > > longer rounded to double, however from my reading of the code, the rounding > > doesn't seem intended. However, if it is, I suggest introducing an explicit > > cast, to document the intent. > > > > Dan > > > From 1fecc521dc43b25366cd4a3062964ff3abc7506e Mon Sep 17 00:00:00 2001 > > From: Dan Gohman > > Date: Fri, 18 Oct 2019 06:22:49 -0700 > > Subject: [PATCH] Use `fabsl` instead of `fabs` on long double in floatscan.c > > > > This fixes a compiler warning: > > > > floatscan.c:304:13: warning: absolute value function 'fabs' given an argument > > of type 'long double' but has parameter of type 'double' which may cause > > truncation of value [-Wabsolute-value] > > the bug can cause spurious errno=ERANGE setting when > converting decimal string to long double on targets > where LDBL_MANT_DIG > DBL_MANT_DIG. > > i believe there is no other side-effect. > > example reproducer (should print 0 errno, current musl > prints 34 on aarch64): > > #include > #include > #include > #include > int main() > { > char buf[100]; > sprintf(buf, "%.42Le", LDBL_MAX); > errno = 0; > if (strtold(buf, 0) != LDBL_MAX) return -1; > printf("%s %d\n", buf, errno); > } > > > > --- > > src/internal/floatscan.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/internal/floatscan.c b/src/internal/floatscan.c > > index 278bf250..99a1ec29 100644 > > --- a/src/internal/floatscan.c > > +++ b/src/internal/floatscan.c > > @@ -301,7 +301,7 @@ static long double decfloat(FILE *f, int c, int bits, int emin, int sign, int po > > y -= bias; > > > > if ((e2+LDBL_MANT_DIG & INT_MAX) > emax-5) { > > - if (fabs(y) >= CONCAT(0x1p, LDBL_MANT_DIG)) { > > + if (fabsl(y) >= CONCAT(CONCAT(0x1p, LDBL_MANT_DIG), l)) { > > if (denormal && bits==LDBL_MANT_DIG+e2-emin) > > denormal = 0; > > y *= 0.5; > > -- > > 2.17.1 > > Thanks for checking this. I'm committing with the double-concat replaced with the 2/LDBL_EPSILON idiom used in printf; rather than worrying about whether this part of the change is needed it seems to make more sense just to get rid of the dependency on being able to do this hackish token concatenaton. Rich