From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14839 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Update ctype data to Unicode 12.1.0 Date: Sun, 20 Oct 2019 10:59:15 -0400 Message-ID: <20191020145915.GD16318@brightrain.aerifal.cx> References: <20191012212742.29880-1-el01049@gmail.com> <20191012223947.GH16318@brightrain.aerifal.cx> <20191014130709.GL16318@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="15298"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-14855-gllmg-musl=m.gmane.org@lists.openwall.com Sun Oct 20 16:59:35 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1iMCgA-0003sU-6Z for gllmg-musl@m.gmane.org; Sun, 20 Oct 2019 16:59:34 +0200 Original-Received: (qmail 20417 invoked by uid 550); 20 Oct 2019 14:59:30 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 20396 invoked from network); 20 Oct 2019 14:59:29 -0000 Content-Disposition: inline In-Reply-To: Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:14839 Archived-At: On Sun, Oct 20, 2019 at 11:53:15AM +0300, Eleftherios Kritikos wrote: > Is anything else we could do to get this merged? Thanks for pinging. I think we just need to go with the previous __STDC_ISO_10646__ macro value for now until there's a new one. I don't think it's a conformance problem to support additional new characters we don't advertise support for with the macro, so it's not a big deal. I can add it as a separate commit and update later with another once there's a new value to be used. Sorry for not getting to this sooner. I do want to run over the chartable tools change and make sure there's nothing unexpected that could cause problems, and didn't want to get bogged down in that before release. BTW are there any new case mappings needed too? I can handle those if so. (The current case mapping code needs manual work to update; I have a draft replacement that won't need manual work I should really get around to integrating.) Rich > On Mon, Oct 14, 2019 at 4:57 PM Eleftherios Kritikos > wrote: > > > Actually now that I read the ISO spec again, it seems to correspond to > > Unicode 11 :( so I think ISO/IEC 10646 has not catch up with Unicode 12 > > yet. Not sure what we should do in this case. > > > > On Mon, Oct 14, 2019 at 2:51 PM Eleftherios Kritikos > > wrote: > > > >> From what I read from here: > >> > >> > >> https://stackoverflow.com/questions/12590255/what-does-stdc-iso-10646-exactly-mean > >> > >> and here: > >> > >> https://standards.iso.org/ittf/PubliclyAvailableStandards/index.html > >> > >> it seems like the latest ISO/IEC 10646 standard that most closely match > >> Unicode 12.1.0 is ISO/IEC 10646:2017/Amd 2:2019 (fifth edition 2017, > >> amendment 2). > >> > >> From what I read in the document here: > >> https://standards.iso.org/ittf/PubliclyAvailableStandards/c073773_ISO_IEC_10646_2017_Amd_2_2019%20(E).zip > >> > >> on first page, this amendment was made on 2019-06. So I would guess that > >> the correct value should be: > >> > >> ``` > >> #define __STDC_ISO_10646__ 201906L > >> ``` > >> > >> All this with a grain of salt as this is the first time I am looking at > >> ISO/IEC 10646. > >> > >> Thanks for looking into this! > >> > >> Regards, > >> Lefteris > >> > >> > >> > >> On Mon, Oct 14, 2019 at 2:07 PM Rich Felker wrote: > >> > >>> On Sat, Oct 12, 2019 at 11:56:44PM +0100, Eleftherios Kritikos wrote: > >>> > Yes. I also created a merge request for musl-chartable-tools > >>> > https://github.com/richfelker/musl-chartable-tools/pull/2 > >>> > >>> Thanks. stdc-predef.h also needs to be updated with a new value for > >>> __STD_ISO_10646__. Do you know the right yyyymm value it should have > >>> for this version of Unicode? > >>> > >>> Rich > >>> > >>> > >>> > On Sat, 12 Oct 2019, 11:40 pm Rich Felker, wrote: > >>> > > >>> > > On Sat, Oct 12, 2019 at 10:27:42PM +0100, u_quark wrote: > >>> > > > --- > >>> > > > src/ctype/alpha.h | 159 > >>> +++++++++++++++++++++------------------- > >>> > > > src/ctype/nonspacing.h | 88 ++++++++++++----------- > >>> > > > src/ctype/punct.h | 160 > >>> ++++++++++++++++++++++------------------- > >>> > > > src/ctype/wide.h | 26 +++---- > >>> > > > 4 files changed, 232 insertions(+), 201 deletions(-) > >>> > > > >>> > > Is this done just by dropping the new Unicode files into > >>> > > musl-chartable-tools and running make? > >>> > > > >>> > > Rich > >>> > > > >>> > >>