From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14931 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Petr Vorel Newsgroups: gmane.linux.lib.musl.general Subject: Re: [RFC] fanotify_event_info_fid incompatibility Date: Tue, 12 Nov 2019 21:30:19 +0100 Message-ID: <20191112203019.GA19417@x230> References: <20191112200520.GA13138@x230> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="245327"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.12.2 (2019-09-21) Cc: Szabolcs Nagy , musl@lists.openwall.com To: Rich Felker Original-X-From: musl-return-14947-gllmg-musl=m.gmane.org@lists.openwall.com Tue Nov 12 21:30:37 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1iUco9-0011hj-9o for gllmg-musl@m.gmane.org; Tue, 12 Nov 2019 21:30:37 +0100 Original-Received: (qmail 28061 invoked by uid 550); 12 Nov 2019 20:30:34 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 28029 invoked from network); 12 Nov 2019 20:30:34 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kEajWPyBmYDwGj62oBl9KBAQFwEItOdzLLeHTkv9uTc=; b=sanMnAo+O2Zau/SySrEOiRs53zMXc0IuSf9OSRvjGtfc/CrPcPRuM3tqK0ELdPVeNm UNUq5Bp3flcoNKb+k36ZWAOWp6VqqnTMAKTxRfmJIM7m9F5X54Z1jB7a+l0HNAsJBsvw 1y8FwMzX5w2c4k431QJhEwpgqtPADR5CUgbLg11nmIoYy16zQyZqWwyhxHHEfPZmDcP8 MmnymqlInLE7rVlDolytfRcMP2u0H+us7mJ2uGiA5u5BULGCnfu5BnhorADi2So4b0yb NuKatGeAhpCpvDOKQfnMnpXWabQtblsTPZ1U4sk8BWK35u4uL8AVNEsItqOYSd4mN8WT DZ2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=kEajWPyBmYDwGj62oBl9KBAQFwEItOdzLLeHTkv9uTc=; b=V7hYBcU3Sh9e7xy7VBGBEacoZtZ3AV7m05r2fiLmwTTn1io5sV3yfxMO2t0fX8gjVd 45hHjA4OH6d43enGB4PkJZwQMuUbBAg/IjbjQugg8E4Cen1Xvj0zJt7sTa4l3iw2cTZR hyE00zOgQ1E/Ol4k05lYvbigZdok42hzTtQav/oJ5aKIestFdUPy+xWOZ++GO7JXXagD Ipzdjx7cofsXnMTXUdtfN042P1I01nHp+qAup7v9lS38WGy32hgURDQZQPpzOJTES2YV Y9bYanGqchW9iPiOHsiyyynV1cTEedJ2ri/b+OoGjwOJFuJBPoq7IoXm10uvkXB9VHLy HabQ== X-Gm-Message-State: APjAAAX3EDipdgT2Z9Te4uXD3jJU7XOUOv1DU9RopzhCfPSbJYPiuX1x 5ZVcW3iVWvjQUADlOz2irGsnGKp/ X-Google-Smtp-Source: APXvYqzMs2POmrNINXdyRzxaK2MN/WrwM6sjrRD4aT3ai+uLmJoe/dNJAjqIGfHWK235iYE+vM9OoA== X-Received: by 2002:a5d:4201:: with SMTP id n1mr25426599wrq.372.1573590622692; Tue, 12 Nov 2019 12:30:22 -0800 (PST) Content-Disposition: inline In-Reply-To: <20191112200520.GA13138@x230> Xref: news.gmane.org gmane.linux.lib.musl.general:14931 Archived-At: Hi, > musl defines struct fanotify_event_info_fid member fsid as fsid_t. This > conflicts with version from Linux kernel, which defines it as __kernel_fsid_t > (musl's fsid_t has int __val[2], kernel's __kernel_fsid_t has int val[2]). > I see commit 32b82cf5 ("fix the fsid_t structure to match name of __val"), > which looks correct to me. > I also think it's wrong, that other libc (at least glibc, uclibc-ng, bionic) > don't define fanotify_event_info_fid and other structs thus users are forced to > use definition from . But can be something done with this > incompatibility? BTW this incompatibility was added quite recently, in f67b3c17 ("sys/fanotify.h: update for linux v5.1") in v1.1.23. Kind regards, Petr