mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: "wangjianjian (C)" <wangjianjian3@huawei.com>
Cc: "musl@lists.openwall.com" <musl@lists.openwall.com>,
	"Songyunlong (Euler)" <yunlong.song@huawei.com>
Subject: Re: [PATCH] ftello: Need adjust file offset before switching to write
Date: Wed, 18 Dec 2019 08:46:36 -0500	[thread overview]
Message-ID: <20191218134636.GM1666@brightrain.aerifal.cx> (raw)
In-Reply-To: <07082d7e15024b06ba261fbb4e29eac5@huawei.com>

On Wed, Dec 18, 2019 at 10:18:16AM +0000, wangjianjian (C) wrote:
> Consider below code flow:
> 
> FILE *fp = fopen("foobar", "w+");
> fputs("hello", fp);
> rewind(fp);
> fgetc(fp);
> ungetc('x', fp);
> fputs("world", fp);
  ^^^^^^^^^^^^^^^^^^^

This line produces UB. You can't perform a write after ungetc without
an intervening successful seek (or hitting EOF).

Rich


  reply	other threads:[~2019-12-18 13:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 10:18 wangjianjian (C)
2019-12-18 13:46 ` Rich Felker [this message]
2019-12-19  2:47   ` 答复: [musl] " wangjianjian (C)
2019-12-19  3:03     ` Rich Felker
2019-12-19  3:19       ` 答复: " wangjianjian (C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218134636.GM1666@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    --cc=wangjianjian3@huawei.com \
    --cc=yunlong.song@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).