mailing list of musl libc
 help / color / mirror / code / Atom feed
From: David Miller <davem@davemloft.net>
To: AWilcox@Wilcox-Tech.com
Cc: netdev@vger.kernel.org, linux-api@vger.kernel.org,
	musl@lists.openwall.com
Subject: Re: [PATCH] uapi: Prevent redefinition of struct iphdr
Date: Wed, 25 Dec 2019 16:34:11 -0800 (PST)	[thread overview]
Message-ID: <20191225.163411.1590483851343305623.davem@davemloft.net> (raw)
In-Reply-To: <20191222060227.7089-1-AWilcox@Wilcox-Tech.com>

From: "A. Wilcox" <AWilcox@Wilcox-Tech.com>
Date: Sun, 22 Dec 2019 00:02:27 -0600

> @@ -83,6 +83,13 @@
>  
>  #define IPV4_BEET_PHMAXLEN 8
>  
> +/* Allow libcs to deactivate this - musl has its own copy in <netinet/ip.h> */
> +
> +#ifndef __UAPI_DEF_IPHDR
> +#define __UAPI_DEF_IPHDR	1
> +#endif

How is this a musl-only problem?  I see that glibc also defines struct iphdr
in netinet/ip.h, so why doesn't it also suffer from this?

I find it really strange that this, therefore, only happens for musl
and we haven't had thousands of reports of this conflict with glibc
over the years.

I want an explanation, and suitably appropriate adjustments to the commit
message and comments of this change.

Thank you.


  reply	other threads:[~2019-12-26  0:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-22  6:02 A. Wilcox
2019-12-26  0:34 ` David Miller [this message]
2019-12-26  1:05   ` Rich Felker
2019-12-26  3:49     ` [musl] " David Miller
2019-12-26 11:13       ` Daniel Kolesa
2019-12-30 17:12         ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191225.163411.1590483851343305623.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=AWilcox@Wilcox-Tech.com \
    --cc=linux-api@vger.kernel.org \
    --cc=musl@lists.openwall.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).