From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/15062 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: David Miller Newsgroups: gmane.linux.network,gmane.linux.kernel.api,gmane.linux.lib.musl.general Subject: Re: [PATCH] uapi: Prevent redefinition of struct iphdr Date: Wed, 25 Dec 2019 16:34:11 -0800 (PST) Message-ID: <20191225.163411.1590483851343305623.davem@davemloft.net> References: <20191222060227.7089-1-AWilcox@Wilcox-Tech.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="219627"; mail-complaints-to="usenet@blaine.gmane.org" Cc: netdev@vger.kernel.org, linux-api@vger.kernel.org, musl@lists.openwall.com To: AWilcox@Wilcox-Tech.com Original-X-From: netdev-owner@vger.kernel.org Thu Dec 26 01:34:15 2019 Return-path: Envelope-to: gl-netdev-2@m.gmane.org Original-Received: from vger.kernel.org ([209.132.180.67]) by blaine.gmane.org with esmtp (Exim 4.89) (envelope-from ) id 1ikH6U-000uv4-Ba for gl-netdev-2@m.gmane.org; Thu, 26 Dec 2019 01:34:14 +0100 Original-Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726976AbfLZAeN (ORCPT ); Wed, 25 Dec 2019 19:34:13 -0500 Original-Received: from shards.monkeyblade.net ([23.128.96.9]:36614 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726879AbfLZAeN (ORCPT ); Wed, 25 Dec 2019 19:34:13 -0500 Original-Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0AFFD15386613; Wed, 25 Dec 2019 16:34:12 -0800 (PST) In-Reply-To: <20191222060227.7089-1-AWilcox@Wilcox-Tech.com> X-Mailer: Mew version 6.8 on Emacs 26.1 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 25 Dec 2019 16:34:12 -0800 (PST) Original-Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Xref: news.gmane.org gmane.linux.network:654534 gmane.linux.kernel.api:39127 gmane.linux.lib.musl.general:15062 Archived-At: From: "A. Wilcox" Date: Sun, 22 Dec 2019 00:02:27 -0600 > @@ -83,6 +83,13 @@ > > #define IPV4_BEET_PHMAXLEN 8 > > +/* Allow libcs to deactivate this - musl has its own copy in */ > + > +#ifndef __UAPI_DEF_IPHDR > +#define __UAPI_DEF_IPHDR 1 > +#endif How is this a musl-only problem? I see that glibc also defines struct iphdr in netinet/ip.h, so why doesn't it also suffer from this? I find it really strange that this, therefore, only happens for musl and we haven't had thousands of reports of this conflict with glibc over the years. I want an explanation, and suitably appropriate adjustments to the commit message and comments of this change. Thank you.