mailing list of musl libc
 help / color / mirror / code / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: Rich Felker <dalias@libc.org>,
	linux-fsdevel@vger.kernel.org, musl@lists.openwall.com,
	linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
	linux-cifs@vger.kernel.org
Subject: Re: getdents64 lost direntries with SMB/NFS and buffer size < unknown threshold
Date: Wed, 25 Dec 2019 22:56:06 -0500	[thread overview]
Message-ID: <20191226035606.GB10794@mit.edu> (raw)
In-Reply-To: <87a77g2o2o.fsf@mid.deneb.enyo.de>

On Wed, Dec 25, 2019 at 08:38:07PM +0100, Florian Weimer wrote:
> 32 bits are simply not enough storage space for the cookie.  Hashing
> just masks the presence of these bugs, but does not eliminate them
> completely.

Arguably 64 bits is not enough space for the cookie.  I'd be a lot
happier if it was 128 or 256 bits.  This is just one of those places
where POSIX is Really Broken(tm).  Unfortunately, NFS only gives us 64
bits for the readdir/readdirplus cookie, so we're kind of stuck with
it.

					- Ted


      reply	other threads:[~2019-12-26  3:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20  0:15 Rich Felker
2019-11-20 19:57 ` [musl] " Florian Weimer
2019-11-20 20:59   ` Rich Felker
2019-11-21 17:54     ` Theodore Y. Ts'o
2019-12-25 19:38       ` Florian Weimer
2019-12-26  3:56         ` Theodore Y. Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191226035606.GB10794@mit.edu \
    --to=tytso@mit.edu \
    --cc=dalias@libc.org \
    --cc=fw@deneb.enyo.de \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).