mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] mips: Use fpregset_t for fpregs element
Date: Wed, 1 Jan 2020 15:47:31 -0500	[thread overview]
Message-ID: <20200101204731.GL30412@brightrain.aerifal.cx> (raw)
In-Reply-To: <20191218220237.3636945-1-raj.khem@gmail.com>

On Wed, Dec 18, 2019 at 02:02:37PM -0800, Khem Raj wrote:
> it helps in fixing type errors seen in applications where the elements
> of mcontext_t fpregs is accessing struct elements by name
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  arch/mips/bits/signal.h | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/bits/signal.h b/arch/mips/bits/signal.h
> index 1a84de59..e1d97ac7 100644
> --- a/arch/mips/bits/signal.h
> +++ b/arch/mips/bits/signal.h
> @@ -19,14 +19,18 @@ typedef struct {
>  } fpregset_t;
>  struct sigcontext {
>  	unsigned sc_regmask, sc_status;
> -	unsigned long long sc_pc, sc_regs[32], sc_fpregs[32];
> +	unsigned long long sc_pc;
> +	gregset_t sc_regs;
> +	fpregset_t sc_fpregs;
>  	unsigned sc_ownedfp, sc_fpc_csr, sc_fpc_eir, sc_used_math, sc_dsp;
>  	unsigned long long sc_mdhi, sc_mdlo;
>  	unsigned long sc_hi1, sc_lo1, sc_hi2, sc_lo2, sc_hi3, sc_lo3;
>  };
>  typedef struct {
>  	unsigned regmask, status;
> -	unsigned long long pc, gregs[32], fpregs[32];
> +	unsigned long long pc;
> +	gregset_t gregs;
> +	fpregset_t fpregs;
>  	unsigned ownedfp, fpc_csr, fpc_eir, used_math, dsp;
>  	unsigned long long mdhi, mdlo;
>  	unsigned long hi1, lo1, hi2, lo2, hi3, lo3;
> -- 
> 2.24.1

Merged.


      reply	other threads:[~2020-01-01 20:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 22:02 Khem Raj
2020-01-01 20:47 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200101204731.GL30412@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).