From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: [musl] [PATCH] math: move x86-family remainder functions to C
Date: Tue, 14 Jan 2020 23:41:19 +0300 [thread overview]
Message-ID: <20200114204119.32154-1-amonakov@ispras.ru> (raw)
In-Reply-To: <alpine.LNX.2.20.13.2001051915090.31907@monopod.intra.ispras.ru>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
---
For an unclear reason commit 5d01ab4ac64b913c537e91f7c01d5c8e910151da
did not add long double aliases dreml and finitel. This patch
preserves the oddity.
src/math/i386/remainder.c | 12 ++++++++++++
src/math/i386/remainder.s | 14 --------------
src/math/i386/remainderf.c | 12 ++++++++++++
src/math/i386/remainderf.s | 14 --------------
src/math/i386/remainderl.c | 9 +++++++++
src/math/i386/remainderl.s | 11 -----------
src/math/x86_64/remainderl.c | 9 +++++++++
src/math/x86_64/remainderl.s | 11 -----------
8 files changed, 42 insertions(+), 50 deletions(-)
create mode 100644 src/math/i386/remainder.c
delete mode 100644 src/math/i386/remainder.s
create mode 100644 src/math/i386/remainderf.c
delete mode 100644 src/math/i386/remainderf.s
create mode 100644 src/math/i386/remainderl.c
delete mode 100644 src/math/i386/remainderl.s
create mode 100644 src/math/x86_64/remainderl.c
delete mode 100644 src/math/x86_64/remainderl.s
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0009-math-move-x86-family-remainder-functions-to-C.patch --]
[-- Type: text/x-patch; name="0009-math-move-x86-family-remainder-functions-to-C.patch", Size: 3124 bytes --]
diff --git a/src/math/i386/remainder.c b/src/math/i386/remainder.c
new file mode 100644
index 00000000..c083df90
--- /dev/null
+++ b/src/math/i386/remainder.c
@@ -0,0 +1,12 @@
+#include <math.h>
+
+double remainder(double x, double y)
+{
+ unsigned short fpsr;
+ // fprem1 does not introduce excess precision into x
+ do __asm__ ("fprem1; fnstsw %%ax" : "+t"(x), "=a"(fpsr) : "u"(y));
+ while (fpsr & 0x400);
+ return x;
+}
+
+weak_alias(remainder, drem);
diff --git a/src/math/i386/remainder.s b/src/math/i386/remainder.s
deleted file mode 100644
index ab1da95d..00000000
--- a/src/math/i386/remainder.s
+++ /dev/null
@@ -1,14 +0,0 @@
-.global remainder
-.type remainder,@function
-remainder:
-.weak drem
-.type drem,@function
-drem:
- fldl 12(%esp)
- fldl 4(%esp)
-1: fprem1
- fnstsw %ax
- sahf
- jp 1b
- fstp %st(1)
- ret
diff --git a/src/math/i386/remainderf.c b/src/math/i386/remainderf.c
new file mode 100644
index 00000000..280207d2
--- /dev/null
+++ b/src/math/i386/remainderf.c
@@ -0,0 +1,12 @@
+#include <math.h>
+
+float remainderf(float x, float y)
+{
+ unsigned short fpsr;
+ // fprem1 does not introduce excess precision into x
+ do __asm__ ("fprem1; fnstsw %%ax" : "+t"(x), "=a"(fpsr) : "u"(y));
+ while (fpsr & 0x400);
+ return x;
+}
+
+weak_alias(remainderf, dremf);
diff --git a/src/math/i386/remainderf.s b/src/math/i386/remainderf.s
deleted file mode 100644
index 6a7378a3..00000000
--- a/src/math/i386/remainderf.s
+++ /dev/null
@@ -1,14 +0,0 @@
-.global remainderf
-.type remainderf,@function
-remainderf:
-.weak dremf
-.type dremf,@function
-dremf:
- flds 8(%esp)
- flds 4(%esp)
-1: fprem1
- fnstsw %ax
- sahf
- jp 1b
- fstp %st(1)
- ret
diff --git a/src/math/i386/remainderl.c b/src/math/i386/remainderl.c
new file mode 100644
index 00000000..8cf75071
--- /dev/null
+++ b/src/math/i386/remainderl.c
@@ -0,0 +1,9 @@
+#include <math.h>
+
+long double remainderl(long double x, long double y)
+{
+ unsigned short fpsr;
+ do __asm__ ("fprem1; fnstsw %%ax" : "+t"(x), "=a"(fpsr) : "u"(y));
+ while (fpsr & 0x400);
+ return x;
+}
diff --git a/src/math/i386/remainderl.s b/src/math/i386/remainderl.s
deleted file mode 100644
index b41518ed..00000000
--- a/src/math/i386/remainderl.s
+++ /dev/null
@@ -1,11 +0,0 @@
-.global remainderl
-.type remainderl,@function
-remainderl:
- fldt 16(%esp)
- fldt 4(%esp)
-1: fprem1
- fnstsw %ax
- sahf
- jp 1b
- fstp %st(1)
- ret
diff --git a/src/math/x86_64/remainderl.c b/src/math/x86_64/remainderl.c
new file mode 100644
index 00000000..8cf75071
--- /dev/null
+++ b/src/math/x86_64/remainderl.c
@@ -0,0 +1,9 @@
+#include <math.h>
+
+long double remainderl(long double x, long double y)
+{
+ unsigned short fpsr;
+ do __asm__ ("fprem1; fnstsw %%ax" : "+t"(x), "=a"(fpsr) : "u"(y));
+ while (fpsr & 0x400);
+ return x;
+}
diff --git a/src/math/x86_64/remainderl.s b/src/math/x86_64/remainderl.s
deleted file mode 100644
index cb3857b4..00000000
--- a/src/math/x86_64/remainderl.s
+++ /dev/null
@@ -1,11 +0,0 @@
-.global remainderl
-.type remainderl,@function
-remainderl:
- fldt 24(%rsp)
- fldt 8(%rsp)
-1: fprem1
- fnstsw %ax
- testb $4,%ah
- jnz 1b
- fstp %st(1)
- ret
next prev parent reply other threads:[~2020-01-14 20:41 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 16:35 math patches for moving bare asm to C inline asm Alexander Monakov
2020-01-05 16:36 ` [PATCH] math: move x86_64 fabs, fabsf to C with " Alexander Monakov
2020-01-05 20:05 ` Rich Felker
2020-01-05 21:32 ` Alexander Monakov
2020-01-05 22:43 ` Rich Felker
2020-01-06 8:17 ` Alexander Monakov
2020-01-06 8:40 ` [PATCH] math: move more x86-family fabs functions to C Alexander Monakov
2020-03-21 17:06 ` [musl] " Rich Felker
2020-01-06 16:50 ` [PATCH] math: move trivial x86-family sqrt " Alexander Monakov
2020-01-06 17:43 ` [PATCH] math: move i386 sqrtf " Alexander Monakov
2020-01-06 18:32 ` Pascal Cuoq
2020-01-09 15:55 ` Alexander Monakov
2020-01-09 17:00 ` Rich Felker
2020-01-09 21:00 ` Szabolcs Nagy
2020-01-09 22:00 ` Rich Felker
2020-01-09 23:18 ` Szabolcs Nagy
2020-01-10 2:07 ` Rich Felker
2020-01-10 9:17 ` Szabolcs Nagy
2020-01-14 17:59 ` [musl] " Alexander Monakov
2020-01-14 18:47 ` Szabolcs Nagy
2020-01-07 13:06 ` [PATCH] math: move i386 sqrt " Alexander Monakov
2020-01-08 7:26 ` Rich Felker
2020-03-21 17:53 ` [musl] " Rich Felker
2020-03-21 17:57 ` Rich Felker
2020-03-21 20:30 ` Alexander Monakov
2020-01-11 15:06 ` [PATCH] math: move x86_64 (l)lrint(f) functions " Alexander Monakov
2020-01-11 15:23 ` [PATCH] math: move more x86-family lrint " Alexander Monakov
2020-01-11 16:07 ` Rich Felker
2020-01-11 16:22 ` Rich Felker
2020-01-14 11:54 ` [musl] [PATCH] math: move x86-family rint " Alexander Monakov
2020-01-14 18:17 ` [musl] Q: dealing with missing removal of excess precision Alexander Monakov
2020-01-14 18:50 ` Szabolcs Nagy
2020-01-14 18:58 ` Rich Felker
2020-01-14 19:53 ` Alexander Monakov
2020-02-06 14:51 ` Rich Felker
2020-02-06 17:15 ` Alexander Monakov
2020-02-06 17:46 ` Rich Felker
2020-02-06 19:03 ` Rich Felker
2020-02-06 20:02 ` Rich Felker
2020-02-06 22:08 ` Szabolcs Nagy
2020-02-22 19:59 ` Rich Felker
2020-02-22 20:21 ` Alexander Monakov
2020-02-23 0:19 ` Rich Felker
2020-02-23 16:14 ` Alexander Monakov
2020-03-20 18:12 ` Rich Felker
2020-03-22 1:19 ` Rich Felker
2020-03-22 17:40 ` Alexander Monakov
2020-03-22 17:53 ` Rich Felker
2020-03-22 18:51 ` Alexander Monakov
2020-03-22 19:10 ` Rich Felker
2020-03-22 19:46 ` Alexander Monakov
2020-01-14 20:41 ` Alexander Monakov [this message]
2020-01-15 6:54 ` [musl] [PATCH] math: move x86-family remainder functions to C Szabolcs Nagy
2020-01-15 15:44 ` [musl] [PATCH] math: move x86-family fmod " Alexander Monakov
2020-01-16 21:00 ` [musl] [PATCH] math: add x86_64 remquol Alexander Monakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114204119.32154-1-amonakov@ispras.ru \
--to=amonakov@ispras.ru \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).