From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.2 Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by inbox.vuxu.org (OpenSMTPD) with SMTP id 3b367409 for ; Wed, 15 Jan 2020 15:46:08 +0000 (UTC) Received: (qmail 31949 invoked by uid 550); 15 Jan 2020 15:46:06 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 31924 invoked from network); 15 Jan 2020 15:46:06 -0000 Date: Wed, 15 Jan 2020 10:45:53 -0500 From: Rich Felker To: musl@lists.openwall.com Message-ID: <20200115154553.GH30412@brightrain.aerifal.cx> References: <20190913184432.29753-1-armccurdy@gmail.com> <20190913184432.29753-2-armccurdy@gmail.com> <20190913185910.GK9017@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: Rich Felker Subject: Re: [musl] [PATCH 2/2] Add big-endian support to ARM assembler memcpy On Fri, Sep 13, 2019 at 01:38:34PM -0700, Andre McCurdy wrote: > On Fri, Sep 13, 2019 at 11:59 AM Rich Felker wrote: > > > > On Fri, Sep 13, 2019 at 11:44:32AM -0700, Andre McCurdy wrote: > > > Allow the existing ARM assembler memcpy implementation to be used for > > > both big and little endian targets. > > > > Nice. I don't want to merge this just before release, but as long as > > it looks ok I should be able to review and merge it afterward. > > > > Note that I'd really like to replace this giant file with C using > > inline asm just for the inner block copies and C for all the flow > > control, but I don't mind merging this first as long as it's correct. > > Sounds good. I'll wait for your feedback after the upcoming release. Sorry this dropped off my radar. I'd like to merge at least the thumb part since it's simple enough to review quickly and users have actually complained about memcpy being slow on armv7 with -mthumb as default. Rich