mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] math/x32: correct lrintl.s for 32-bit long
Date: Sat, 18 Jan 2020 17:51:42 +0100	[thread overview]
Message-ID: <20200118165142.GG23985@port70.net> (raw)
In-Reply-To: <20200118161516.22758-1-amonakov@ispras.ru>

* Alexander Monakov <amonakov@ispras.ru> [2020-01-18 19:15:16 +0300]:
> ---
> Looks like the implementation copied from x86_64 was not adjusted for
> 32-bit 'long' on x32, but apart from failure to raise FE_INVALID this
> error was harmless.

fenv behaviour is wrong on out-of-range values, not just
because of missing invalid, but spurious inexact too.

thanks for finding this.

> 
>  src/math/x32/lrintl.s | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

> diff --git a/src/math/x32/lrintl.s b/src/math/x32/lrintl.s
> index ee97d1cf..d4355c32 100644
> --- a/src/math/x32/lrintl.s
> +++ b/src/math/x32/lrintl.s
> @@ -2,6 +2,6 @@
>  .type lrintl,@function
>  lrintl:
>  	fldt 8(%esp)
> -	fistpll 8(%esp)
> -	mov 8(%esp),%rax
> +	fistpl 8(%esp)
> +	movl 8(%esp),%eax
>  	ret


  reply	other threads:[~2020-01-18 16:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-18 16:15 Alexander Monakov
2020-01-18 16:51 ` Szabolcs Nagy [this message]
2020-01-25 16:38 ` Alexander Monakov
2020-01-27 18:03   ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200118165142.GG23985@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).