From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [musl] PATCH: Fix cfi awk scripts for gawk 5 warning
Date: Mon, 20 Jan 2020 16:00:06 -0500 [thread overview]
Message-ID: <20200120210006.GN30412@brightrain.aerifal.cx> (raw)
In-Reply-To: <20200108200640.GV30412@brightrain.aerifal.cx>
On Wed, Jan 08, 2020 at 03:06:40PM -0500, Rich Felker wrote:
> On Wed, Jan 08, 2020 at 01:48:09PM -0600, Will Dietz wrote:
> > When `awk` is gawk 5.0.1, the cfi awk scripts print a warning
> > due to unnecessarily escaping '@' character (see attached patch).
> >
> > Warning message example:
> >
> > awk: ./tools/add-cfi.x86_64.awk:79: warning: regexp escape sequence `\@' is not a known regexp operator
> >
> > Trivial patch addressing this is attached.
> >
> > Unsure which awk implementations are relevant,
> > tested with gawk 4.2.1, gawk 5.0.1, and mawk 1.3.4.
> > Also tested with busybox 1.31.1, didn't check config options used (if that matters).
> >
> > For all, `.cfi_startproc` seems to be inserted appropriately on example used for testing
> > (src/math/x86_64/lrintf.s) and no warnings were printed.
> >
> > Minor issue, but seems might as well fix if there aren't awk's requiring escaping '@'.
> >
> > Thanks!
> >
> > ~Will
>
> > From 004799af62609eab3261ea9a75794dd7281ce02e Mon Sep 17 00:00:00 2001
> > From: Will Dietz <w@wdtz.org>
> > Date: Wed, 8 Jan 2020 13:20:44 -0600
> > Subject: [PATCH] tools/add-cfi.{i386,x86_64}.awk: fix for gawk 5, '\@' -> '@'
> >
> > ---
> > tools/add-cfi.i386.awk | 2 +-
> > tools/add-cfi.x86_64.awk | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/add-cfi.i386.awk b/tools/add-cfi.i386.awk
> > index 9162e309..d05037de 100644
> > --- a/tools/add-cfi.i386.awk
> > +++ b/tools/add-cfi.i386.awk
> > @@ -81,7 +81,7 @@ function adjust_sp_offset(delta) {
> > in_function = 0
> > }
> > }
> > -/^\.type [a-zA-Z0-9_]+,\@function/ {
> > +/^\.type [a-zA-Z0-9_]+,@function/ {
> > functions[substr($2, 1, length($2)-10)] = 1
> > }
> > # not interested in assembler directives beyond this, just pass them through
> > diff --git a/tools/add-cfi.x86_64.awk b/tools/add-cfi.x86_64.awk
> > index bbc90daa..7e1513d6 100644
> > --- a/tools/add-cfi.x86_64.awk
> > +++ b/tools/add-cfi.x86_64.awk
> > @@ -76,7 +76,7 @@ function adjust_sp_offset(delta) {
> > in_function = 0
> > }
> > }
> > -/^\.type [a-zA-Z0-9_]+,\@function/ {
> > +/^\.type [a-zA-Z0-9_]+,@function/ {
> > functions[substr($2, 1, length($2)-10)] = 1
> > }
> > # not interested in assembler directives beyond this, just pass them through
> > --
> > 2.25.0-rc1
> >
>
> I think this should be okay, but I'll probably wait until after
> release to commit just in case.
>
> At some point it may make sense to remove these entirely, if we can
> get rid of most of the external asm files.
Others have reported hitting this, and I think it looks fine. I'm
testing with Busybox awk and as long as it works (I expect it to) I'll
include it in this release.
Rich
prev parent reply other threads:[~2020-01-20 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 19:48 Will Dietz
2020-01-08 20:06 ` Rich Felker
2020-01-20 21:00 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120210006.GN30412@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).