From: Rich Felker <dalias@libc.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: 39236@debbugs.gnu.org, musl@lists.openwall.com
Subject: Re: [musl] coreutils cp mishandles error return from lchmod
Date: Wed, 22 Jan 2020 15:56:05 -0500 [thread overview]
Message-ID: <20200122205605.GF30412@brightrain.aerifal.cx> (raw)
In-Reply-To: <87zheffca9.fsf@oldenburg2.str.redhat.com>
On Wed, Jan 22, 2020 at 09:48:14PM +0100, Florian Weimer wrote:
> * Rich Felker:
>
> >> Hmm. The way I read the musl code, the O_PATH descriptor already
> >> exists. At this point, you can just chmod the O_PATH descriptor, and
> >> have the kernel report EOPNOTSUPP if the file system does not support
> >> that.
> >
> > Oh, you mean the second one after it's already open? Maybe that's ok.
>
> Yes, that's what I meant.
>
> > I was concerned it might follow the link and chmod the target at that
> > point.
>
> In my tests, it works. I think it's also documented behavior for chown
> on these pseudo-files.
Do you know where we might find that documentation?
> I also verified that closing an O_PATH descriptor does not release POSIX
> advisory locks for the same file. But I'm wondering if there's still
> something we are missing.
Thanks, I hadn't thought to check that, but wouldn't have expected it
to be a problem since O_PATH is not actually open to the file.
Rich
next prev parent reply other threads:[~2020-01-22 20:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 14:15 Rich Felker
2020-01-22 14:34 ` Florian Weimer
2020-01-22 14:42 ` Rich Felker
2020-01-22 15:08 ` Florian Weimer
2020-01-22 15:15 ` Rich Felker
2020-01-22 15:32 ` Florian Weimer
2020-01-22 16:07 ` Rich Felker
2020-01-22 16:19 ` Florian Weimer
2020-01-22 17:15 ` Rich Felker
2020-01-22 20:48 ` Florian Weimer
2020-01-22 20:56 ` Rich Felker [this message]
2020-01-22 21:05 ` Florian Weimer
2020-01-22 21:55 ` bug#39236: " Paul Eggert
2020-01-22 22:05 ` Rich Felker
2020-02-08 0:37 ` Paul Eggert
2020-02-12 11:50 ` Florian Weimer
2020-02-12 13:05 ` Rich Felker
2020-02-12 19:07 ` Rich Felker
2020-02-12 19:13 ` Florian Weimer
2020-02-12 19:59 ` A. Wilcox
2020-02-12 20:56 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122205605.GF30412@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=39236@debbugs.gnu.org \
--cc=fweimer@redhat.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).