mailing list of musl libc
 help / color / Atom feed
* [musl] [PATCH] math/x32: correct lrintl.s for 32-bit long
@ 2020-01-18 16:15 Alexander Monakov
  2020-01-18 16:51 ` Szabolcs Nagy
  2020-01-25 16:38 ` Alexander Monakov
  0 siblings, 2 replies; 4+ messages in thread
From: Alexander Monakov @ 2020-01-18 16:15 UTC (permalink / raw)
  To: musl

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

---
Looks like the implementation copied from x86_64 was not adjusted for
32-bit 'long' on x32, but apart from failure to raise FE_INVALID this
error was harmless.

 src/math/x32/lrintl.s | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


[-- Warning: decoded text below may be mangled --]
[-- Attachment #2: 0320-math-x32-correct-lrintl.s-for-32-bit-long.patch --]
[-- Type: text/x-patch; name="0320-math-x32-correct-lrintl.s-for-32-bit-long.patch", Size: 291 bytes --]

diff --git a/src/math/x32/lrintl.s b/src/math/x32/lrintl.s
index ee97d1cf..d4355c32 100644
--- a/src/math/x32/lrintl.s
+++ b/src/math/x32/lrintl.s
@@ -2,6 +2,6 @@
 .type lrintl,@function
 lrintl:
 	fldt 8(%esp)
-	fistpll 8(%esp)
-	mov 8(%esp),%rax
+	fistpl 8(%esp)
+	movl 8(%esp),%eax
 	ret

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [musl] [PATCH] math/x32: correct lrintl.s for 32-bit long
  2020-01-18 16:15 [musl] [PATCH] math/x32: correct lrintl.s for 32-bit long Alexander Monakov
@ 2020-01-18 16:51 ` Szabolcs Nagy
  2020-01-25 16:38 ` Alexander Monakov
  1 sibling, 0 replies; 4+ messages in thread
From: Szabolcs Nagy @ 2020-01-18 16:51 UTC (permalink / raw)
  To: musl

* Alexander Monakov <amonakov@ispras.ru> [2020-01-18 19:15:16 +0300]:
> ---
> Looks like the implementation copied from x86_64 was not adjusted for
> 32-bit 'long' on x32, but apart from failure to raise FE_INVALID this
> error was harmless.

fenv behaviour is wrong on out-of-range values, not just
because of missing invalid, but spurious inexact too.

thanks for finding this.

> 
>  src/math/x32/lrintl.s | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

> diff --git a/src/math/x32/lrintl.s b/src/math/x32/lrintl.s
> index ee97d1cf..d4355c32 100644
> --- a/src/math/x32/lrintl.s
> +++ b/src/math/x32/lrintl.s
> @@ -2,6 +2,6 @@
>  .type lrintl,@function
>  lrintl:
>  	fldt 8(%esp)
> -	fistpll 8(%esp)
> -	mov 8(%esp),%rax
> +	fistpl 8(%esp)
> +	movl 8(%esp),%eax
>  	ret


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [musl] [PATCH] math/x32: correct lrintl.s for 32-bit long
  2020-01-18 16:15 [musl] [PATCH] math/x32: correct lrintl.s for 32-bit long Alexander Monakov
  2020-01-18 16:51 ` Szabolcs Nagy
@ 2020-01-25 16:38 ` Alexander Monakov
  2020-01-27 18:03   ` Rich Felker
  1 sibling, 1 reply; 4+ messages in thread
From: Alexander Monakov @ 2020-01-25 16:38 UTC (permalink / raw)
  To: musl

Ping, doesn't appear to be applied yet.

On Sat, 18 Jan 2020, Alexander Monakov wrote:

> ---
> Looks like the implementation copied from x86_64 was not adjusted for
> 32-bit 'long' on x32, but apart from failure to raise FE_INVALID this
> error was harmless.
> 
>  src/math/x32/lrintl.s | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [musl] [PATCH] math/x32: correct lrintl.s for 32-bit long
  2020-01-25 16:38 ` Alexander Monakov
@ 2020-01-27 18:03   ` Rich Felker
  0 siblings, 0 replies; 4+ messages in thread
From: Rich Felker @ 2020-01-27 18:03 UTC (permalink / raw)
  To: musl

On Sat, Jan 25, 2020 at 07:38:07PM +0300, Alexander Monakov wrote:
> Ping, doesn't appear to be applied yet.
> 
> On Sat, 18 Jan 2020, Alexander Monakov wrote:
> 
> > ---
> > Looks like the implementation copied from x86_64 was not adjusted for
> > 32-bit 'long' on x32, but apart from failure to raise FE_INVALID this
> > error was harmless.
> > 
> >  src/math/x32/lrintl.s | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > 

Thanks for pinging! I'd missed that this was something that needed to
be applied now vs the other x86 math patches that are to be applied
after release. Applying now.

Rich

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-18 16:15 [musl] [PATCH] math/x32: correct lrintl.s for 32-bit long Alexander Monakov
2020-01-18 16:51 ` Szabolcs Nagy
2020-01-25 16:38 ` Alexander Monakov
2020-01-27 18:03   ` Rich Felker

mailing list of musl libc

Archives are clonable: git clone --mirror http://inbox.vuxu.org/musl

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.musl


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git