From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [musl] MUSL not including <sys/ttydefaults.h> in <sys/ioctl.h>
Date: Wed, 29 Jan 2020 10:49:25 -0500 [thread overview]
Message-ID: <20200129154925.GI30412@brightrain.aerifal.cx> (raw)
In-Reply-To: <20200129125012.GB29404@dell5510>
On Wed, Jan 29, 2020 at 01:50:12PM +0100, Petr Vorel wrote:
> Hi,
>
> Glibc is including <sys/ttydefaults.h> in <sys/ioctl.h> with following comment:
>
> /* On a Unix system, the system <sys/ioctl.h> probably defines some of
> the symbols we define in <sys/ttydefaults.h> (usually with the same
> values). The code to generate <bits/ioctls.h> has omitted these
> symbols to avoid the conflict, but a Unix program expects <sys/ioctl.h>
> to define them, so we must include <sys/ttydefaults.h> here. */
>
> I guess glibc is (as usual) wrong and therefore users who needs these
> definitions should load also <sys/ttydefaults.h> explicitly.
ioctl.h isn't governed by any current standard, so we could include
sys/ttydefaults.h here, but I don't think it makes sense to. These
macros logically have nothing to do with the ioctl interface; rather
they go with termios. Programs that want them should probably be
including the header explicitly, or better yet not using them at all.
I also found a couple small issues in that header I'm fixing now.
Rich
next prev parent reply other threads:[~2020-01-29 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 12:50 Petr Vorel
2020-01-29 15:49 ` Rich Felker [this message]
2020-01-29 15:55 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129154925.GI30412@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).