From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <musl-return-15326-ml=inbox.vuxu.org@lists.openwall.com>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL,SUBJ_OBFU_PUNCT_FEW autolearn=ham autolearn_force=no
	version=3.4.2
Received: from mother.openwall.net (mother.openwall.net [195.42.179.200])
	by inbox.vuxu.org (OpenSMTPD) with SMTP id eb6b5504
	for <ml@inbox.vuxu.org>;
	Wed, 29 Jan 2020 15:55:44 +0000 (UTC)
Received: (qmail 5725 invoked by uid 550); 29 Jan 2020 15:55:42 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 5704 invoked from network); 29 Jan 2020 15:55:42 -0000
Date: Wed, 29 Jan 2020 16:55:30 +0100
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Message-ID: <20200129155530.GX23985@port70.net>
Mail-Followup-To: musl@lists.openwall.com
References: <20200129125012.GB29404@dell5510>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200129125012.GB29404@dell5510>
User-Agent: Mutt/1.10.1 (2018-07-13)
Subject: Re: [musl] MUSL not including <sys/ttydefaults.h> in <sys/ioctl.h>

* Petr Vorel <pvorel@suse.cz> [2020-01-29 13:50:12 +0100]:
> Hi,
> 
> Glibc is including <sys/ttydefaults.h> in <sys/ioctl.h> with following comment:
> 
> /* On a Unix system, the system <sys/ioctl.h> probably defines some of
>    the symbols we define in <sys/ttydefaults.h> (usually with the same
>    values).  The code to generate <bits/ioctls.h> has omitted these
>    symbols to avoid the conflict, but a Unix program expects <sys/ioctl.h>
>    to define them, so we must include <sys/ttydefaults.h> here.  */
> 
> I guess glibc is (as usual) wrong and therefore users who needs these
> definitions should load also <sys/ttydefaults.h> explicitly.

at some point i did some sys/ioctl.h cleanup
and i don't remember how conciously i omitted
the sys/ttydefaults.h include. (they are both
non-standard headers so in principle including
is ok)

sys/ttydefaults.h is more related to termios.h:
several TTYDEF_* macros depend on termios.h and
termios.h includes it on both glibc and bsd in
non-standard mode i think (termios.h is standard
header). it is weird to include things into
ioctl.h that don't work without termios.h.

i don't think bsd sys/ioctl.h includes it, but
ioctl is very os specific.