From: Rich Felker <dalias@libc.org>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
Florian Weimer <fweimer@redhat.com>,
Gnulib bugs <bug-gnulib@gnu.org>,
musl@lists.openwall.com, 39236@debbugs.gnu.org
Subject: Re: bug#39236: [musl] coreutils cp mishandles error return from lchmod
Date: Wed, 12 Feb 2020 08:05:55 -0500 [thread overview]
Message-ID: <20200212130555.GX1663@brightrain.aerifal.cx> (raw)
In-Reply-To: <87zhdonhxg.fsf@mid.deneb.enyo.de>
On Wed, Feb 12, 2020 at 12:50:19PM +0100, Florian Weimer wrote:
> * Paul Eggert:
>
> > On 1/22/20 2:05 PM, Rich Felker wrote:
> >> I think we're approaching a consensus that glibc should fix this too,
> >> so then it would just be gnulib matching the fix.
> >
> > I installed the attached patch to Gnulib in preparation for the upcoming
> > glibc fix. The patch causes fchmodat with AT_SYMLINK_NOFOLLOW to work on
> > non-symlinks, and similarly for lchmod on non-symlinks. The idea is to
> > avoid this sort of problem in the future, and to let Coreutils etc. work
> > on older platforms as if glibc 2.32 (or whatever) is already in place.
>
> The lchmod implementation based on /proc tickles an XFS bug:
>
> <https://sourceware.org/ml/libc-alpha/2020-02/msg00467.html>
Uhg, why does Linux even let the fs driver see whether the chmod is
being performed via a filename, O_PATH fd, or magic symlink in /proc?
It should just be an operation on the inode.
Rich
next prev parent reply other threads:[~2020-02-12 13:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 14:15 Rich Felker
2020-01-22 14:34 ` Florian Weimer
2020-01-22 14:42 ` Rich Felker
2020-01-22 15:08 ` Florian Weimer
2020-01-22 15:15 ` Rich Felker
2020-01-22 15:32 ` Florian Weimer
2020-01-22 16:07 ` Rich Felker
2020-01-22 16:19 ` Florian Weimer
2020-01-22 17:15 ` Rich Felker
2020-01-22 20:48 ` Florian Weimer
2020-01-22 20:56 ` Rich Felker
2020-01-22 21:05 ` Florian Weimer
2020-01-22 21:55 ` bug#39236: " Paul Eggert
2020-01-22 22:05 ` Rich Felker
2020-02-08 0:37 ` Paul Eggert
2020-02-12 11:50 ` Florian Weimer
2020-02-12 13:05 ` Rich Felker [this message]
2020-02-12 19:07 ` Rich Felker
2020-02-12 19:13 ` Florian Weimer
2020-02-12 19:59 ` A. Wilcox
2020-02-12 20:56 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212130555.GX1663@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=39236@debbugs.gnu.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=fw@deneb.enyo.de \
--cc=fweimer@redhat.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).