From: Rich Felker <dalias@libc.org>
To: "A. Wilcox" <awilfox@adelielinux.org>
Cc: musl@lists.openwall.com
Subject: Re: bug#39236: [musl] coreutils cp mishandles error return from lchmod
Date: Wed, 12 Feb 2020 15:56:46 -0500 [thread overview]
Message-ID: <20200212205646.GG1663@brightrain.aerifal.cx> (raw)
In-Reply-To: <a68c59d8-af1e-8be8-3f66-074d2614ea56@adelielinux.org>
On Wed, Feb 12, 2020 at 01:59:09PM -0600, A. Wilcox wrote:
> On 12/02/2020 13:07, Rich Felker wrote:
> > On Wed, Feb 12, 2020 at 08:05:55AM -0500, Rich Felker wrote:
> >> On Wed, Feb 12, 2020 at 12:50:19PM +0100, Florian Weimer wrote:
> >>> * Paul Eggert:
> >>>
> >>>> On 1/22/20 2:05 PM, Rich Felker wrote:
> >>>>> I think we're approaching a consensus that glibc should fix this too,
> >>>>> so then it would just be gnulib matching the fix.
> >>>>
> >>>> I installed the attached patch to Gnulib in preparation for the upcoming
> >>>> glibc fix. The patch causes fchmodat with AT_SYMLINK_NOFOLLOW to work on
> >>>> non-symlinks, and similarly for lchmod on non-symlinks. The idea is to
> >>>> avoid this sort of problem in the future, and to let Coreutils etc. work
> >>>> on older platforms as if glibc 2.32 (or whatever) is already in place.
> >>>
> >>> The lchmod implementation based on /proc tickles an XFS bug:
> >>>
> >>> <https://sourceware.org/ml/libc-alpha/2020-02/msg00467.html>
> >>
> >> Uhg, why does Linux even let the fs driver see whether the chmod is
> >> being performed via a filename, O_PATH fd, or magic symlink in /proc?
> >> It should just be an operation on the inode.
> >
> > OK, I don't think it's actually clear from the test that the use of
> > the magic symlink is the cause. It's plausible that XFS just always
> > returns failure on success for this operation, and I don't have XFS to
> > test with.
>
>
> My root fs is XFS, but I only have musl to test with. Is there a test
> case I can run on musl to determine the behaviour of XFS for you?
>
> The only glibc distribution that supports my platform is Void, so I
> don't know if the Void glibc spin in a chroot would be sufficient if
> there is no way to do this from a musl system.
We've since found (in the other thread musl list isn't CC'd on) that
this does not seem to be XFS-specific but happens in ext4 too, and is
probably a high level vfs bug.
Rich
prev parent reply other threads:[~2020-02-12 20:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 14:15 Rich Felker
2020-01-22 14:34 ` Florian Weimer
2020-01-22 14:42 ` Rich Felker
2020-01-22 15:08 ` Florian Weimer
2020-01-22 15:15 ` Rich Felker
2020-01-22 15:32 ` Florian Weimer
2020-01-22 16:07 ` Rich Felker
2020-01-22 16:19 ` Florian Weimer
2020-01-22 17:15 ` Rich Felker
2020-01-22 20:48 ` Florian Weimer
2020-01-22 20:56 ` Rich Felker
2020-01-22 21:05 ` Florian Weimer
2020-01-22 21:55 ` bug#39236: " Paul Eggert
2020-01-22 22:05 ` Rich Felker
2020-02-08 0:37 ` Paul Eggert
2020-02-12 11:50 ` Florian Weimer
2020-02-12 13:05 ` Rich Felker
2020-02-12 19:07 ` Rich Felker
2020-02-12 19:13 ` Florian Weimer
2020-02-12 19:59 ` A. Wilcox
2020-02-12 20:56 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212205646.GG1663@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=awilfox@adelielinux.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).