mailing list of musl libc
 help / color / mirror / code / Atom feed
* [musl] [PATCH] stat: Fix chmod
@ 2020-02-19  2:32 Zhang Tianci
  2020-02-19  3:50 ` Rich Felker
  0 siblings, 1 reply; 2+ messages in thread
From: Zhang Tianci @ 2020-02-19  2:32 UTC (permalink / raw)
  To: musl; +Cc: zhangtianci1, yunlong.song

chmod misses `flag` argument when calling the syscall fchmodat.
Although Linux does not use `flag` in fchmodat, but in other system,
fchmodat will get a random value and it will cause flag check error.

Signed-off-by: Zhang Tianci <zhangtianci1@huawei.com>
---
 src/stat/chmod.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/stat/chmod.c b/src/stat/chmod.c
index d4f53c5..e99a146 100644
--- a/src/stat/chmod.c
+++ b/src/stat/chmod.c
@@ -7,6 +7,6 @@ int chmod(const char *path, mode_t mode)
 #ifdef SYS_chmod
 	return syscall(SYS_chmod, path, mode);
 #else
-	return syscall(SYS_fchmodat, AT_FDCWD, path, mode);
+	return syscall(SYS_fchmodat, AT_FDCWD, path, mode, 0);
 #endif
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-19  3:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19  2:32 [musl] [PATCH] stat: Fix chmod Zhang Tianci
2020-02-19  3:50 ` Rich Felker

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).