From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [musl] Considering x86-64 fenv.s to C
Date: Sat, 22 Feb 2020 15:17:04 -0500 [thread overview]
Message-ID: <20200222201704.GL1663@brightrain.aerifal.cx> (raw)
In-Reply-To: <alpine.LRH.2.02.2002031311260.28418@key0.esi.com.au>
On Mon, Feb 03, 2020 at 01:12:35PM +1100, Damian McGuckin wrote:
> On Sun, 2 Feb 2020, Rich Felker wrote:
>
> >Hi. Just checking in to let you know I'm not ignoring you, but
> >might need a bit to task-switch back to following up on this. I'll
> >try to do it in parallel with finishing up the release cycle.
>
> No rush. I have to fight other fires for most of this week anyway.
OK, I'm going to start review and follow-up now. Sorry it's taken so
long. Back-and-forth over time64 concerns in applications & testing,
documenting time64 transition for users, etc. took a lot longer than I
had hoped but it's done now. :-)
First comment: I couldn't find (maybe I missed?) what you intend fore
the contents of fenv-generic.c and fenv-trivial.c to be, but I don't
see what you want them for. fenv.c should just use the macros/inlines
the fenv_arch.h defines, naturally collapsing to empty functions when
they do nothing (for softfloat archs).
In general, the idiom of #include "../foo.c" for $(ARCH)/foo.c only
works when the names are the same, so that the arch file is replacing
the one in the parent dir, and there are special cases (subarch
variants) where you want the arch dir to just do the same thing as the
generic file in the parent dir does, or where it's doing approximately
the same thing but with some macros defined to change what it does.
The way you seem to be trying to do it, src/fenv/fenv-generic.c,
src/fenv/fenv-trivial.c, and src/fenv/$(ARCH)/fenv.c would all be
getting built.
A couple minor style things I also spotted right away: If you want an
unsigned 0 constant, 0U is very much preferred to ((unsigned)0), and
not putting the type there at all is preferable unless there's a good
reason you need it (like to make other things in expressions get
coerced to unsigned). Also verbose type names like "unsigned int" in
place of just "unsigned" are not preferred. If they appear in some
existing places in the source, it's by mistake/oversight.
I'll follow up with more interesting technical review soon.
Rich
next prev parent reply other threads:[~2020-02-22 20:17 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 4:30 Damian McGuckin
2020-01-16 15:11 ` Markus Wichmann
2020-01-16 16:14 ` Rich Felker
2020-01-16 18:56 ` Damian McGuckin
2020-01-16 19:33 ` Rich Felker
2020-01-16 21:31 ` Damian McGuckin
2020-01-17 3:36 ` Damian McGuckin
2020-01-17 3:48 ` Damian McGuckin
2020-01-17 3:53 ` David Edelsohn
2020-01-17 14:13 ` Rich Felker
2020-01-17 14:19 ` David Edelsohn
2020-01-17 14:53 ` Rich Felker
2020-01-18 4:45 ` Damian McGuckin
2020-01-18 5:29 ` Rich Felker
2020-01-19 8:50 ` Damian McGuckin
2020-01-19 9:07 ` Damian McGuckin
2020-01-19 10:42 ` Szabolcs Nagy
2020-01-19 12:25 ` Damian McGuckin
2020-01-20 5:32 ` Damian McGuckin
2020-01-20 17:38 ` Rich Felker
2020-01-20 21:11 ` [musl] Triggering Overflow (or Underflow) without triggering Inexact on i386 Damian McGuckin
2020-01-20 22:32 ` Szabolcs Nagy
2020-01-21 3:53 ` [musl] Considering x86-64 fenv.s to C Damian McGuckin
2020-01-21 4:22 ` Rich Felker
2020-01-21 4:46 ` Damian McGuckin
2020-01-21 7:26 ` Damian McGuckin
2020-01-17 16:41 ` Markus Wichmann
2020-01-18 1:15 ` Szabolcs Nagy
2020-01-18 5:03 ` Damian McGuckin
2020-01-18 5:37 ` Rich Felker
2020-01-18 9:40 ` Szabolcs Nagy
2020-01-24 0:42 ` Damian McGuckin
2020-01-24 1:11 ` Rich Felker
2020-01-24 4:13 ` Damian McGuckin
2020-01-24 4:55 ` Rich Felker
2020-01-24 6:08 ` Damian McGuckin
2020-01-24 13:44 ` Rich Felker
2020-01-24 14:45 ` Damian McGuckin
2020-01-24 23:59 ` Damian McGuckin
2020-01-25 0:11 ` Rich Felker
2020-01-26 3:28 ` Damian McGuckin
2020-01-26 3:28 ` Damian McGuckin
2020-01-26 3:30 ` Damian McGuckin
2020-01-26 3:32 ` Damian McGuckin
2020-01-26 5:25 ` Damian McGuckin
2020-01-27 3:32 ` Damian McGuckin
2020-01-27 5:39 ` Damian McGuckin
2020-02-02 0:47 ` Damian McGuckin
2020-02-03 0:54 ` Damian McGuckin
2020-02-03 2:09 ` Rich Felker
2020-02-03 2:12 ` Damian McGuckin
2020-02-22 20:17 ` Rich Felker [this message]
2020-02-22 20:53 ` Damian McGuckin
2020-02-23 5:41 ` Damian McGuckin
2020-02-23 6:25 ` Rich Felker
2020-02-23 8:35 ` Damian McGuckin
2020-02-07 21:25 ` Damian McGuckin
2020-02-07 21:38 ` Rich Felker
2020-02-07 23:53 ` Damian McGuckin
2020-02-09 5:04 ` Damian McGuckin
2020-01-24 7:10 ` Damian McGuckin
2020-01-18 5:04 ` Markus Wichmann
2020-02-03 14:16 [musl] PPC64(LE) support in musl requires ALTIVEC Romain Naour
2020-02-03 14:50 ` Rich Felker
2020-02-05 1:32 ` [musl] Considering x86-64 fenv.s to C Damian McGuckin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200222201704.GL1663@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).