From: Rich Felker <dalias@libc.org>
To: "Andreas Dröscher" <musl@bugfree.ch>
Cc: musl@lists.openwall.com
Subject: Re: [musl] mips32 little endian -ENOSYS is not -(-ENOSYS)
Date: Wed, 11 Mar 2020 19:08:48 -0400 [thread overview]
Message-ID: <20200311230848.GJ11469@brightrain.aerifal.cx> (raw)
In-Reply-To: <df7e3abb-b74b-e09f-28b6-cd8e5d3a7ccd@droescher.ch>
On Wed, Mar 11, 2020 at 10:08:11PM +0100, Andreas Dröscher wrote:
> Am 11.03.20 um 03:18 schrieb Rich Felker:
> >On Wed, Mar 11, 2020 at 03:08:22AM +0100, Andreas Dröscher wrote:
> >>The current implementation of __syscall5, __syscall6 and __syscall7
> >>(those use caller saved registers) violate the calling conventions
> >>of MIPS32 Linux Kernels prior 2.6.35. Those were assuming that the
> >>instruction immediately preceding the SYSCALL instruction was an
> >>instruction for loading the syscall number.
> >>
> >>I’ll will try to rearrange the stack pushes to accommodate this
> >>requirement and report back if I manage to come up with something
> >>presentable.
> >
> >Uhg, so commit 604f8d3d8b08ee4f548de193050ef93a7753c2e0 was probably
> >wrong and there was a reason for the nonsensical code it removed:
> >making old broken kernels happy. I'm not sure if you can just revert
> >it or need to make new changes.
> >
> >Do you know if this "rule" applies to n32/n64 too or just o32?
>
> I've reverted 604f8d3d8b08ee4f548de193050ef93a7753c2e0 and additionally
> replaced all:
> return r7 ? -r2 : r2;
> with
> return (r7 && r2 > 0) ? -r2 : r2;
>
> My software stack (built with OE-Core Zeus) now works almost flawlessly.
> Some Daemons have hiccups but those most likely come from source
> that expects syscalls to always succeed and on my system they are
> simply missing.
>
> Thank you for your helping to sort this out.
>
> You asked about n32/n64. I am not familiar with more modern MIPS Architectures.
> Therefore I can't give any informed answer. I found some documentation:
> https://www.linux-mips.org/wiki/Syscall but it does not give a
> definitive answer. It just points towards "all 3 mips are effected
> by the ordering requirement".
I'm posting a patch series now.
Rich
next prev parent reply other threads:[~2020-03-11 23:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 21:10 Andreas Dröscher
2020-03-11 0:55 ` Rich Felker
2020-03-11 1:19 ` Andreas Dröscher
2020-03-11 1:40 ` Rich Felker
2020-03-11 2:08 ` Andreas Dröscher
2020-03-11 2:18 ` Rich Felker
2020-03-11 21:08 ` Andreas Dröscher
2020-03-11 21:35 ` Rich Felker
2020-03-11 23:08 ` Rich Felker [this message]
2020-03-20 16:34 ` Rich Felker
2020-03-20 22:18 ` Andreas Dröscher
2020-03-20 22:33 ` Rich Felker
2020-03-29 21:46 ` Andreas Dröscher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311230848.GJ11469@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@bugfree.ch \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).