From: Wolf <wolf@wolfsden.cz>
To: musl@lists.openwall.com
Subject: [musl] Proposal to match behaviour of gethostbyname to glibc
Date: Fri, 13 Mar 2020 22:46:48 +0100 [thread overview]
Message-ID: <20200313214648.2qqr5utzyqy5ewsu@wolfsden.cz> (raw)
[-- Attachment #1: Type: text/plain, Size: 1850 bytes --]
Hello,
today I've noticed difference in behavior of gethostbyname in musl and
in glibc. Given /etc/hosts
127.0.0.1 foo.bar foo
127.0.0.1 bar.foo foo
and simple test program
#include <netdb.h>
#include <stdio.h>
int main(int argc, char **argv) {
struct hostent *he = gethostbyname(argv[1]);
printf("Hostname: %s\n", he->h_name);
}
, I've run it both under musl (alpine) and glibc (archlinux).
musl:
/test # ./test foo
Hostname: bar.foo
glibc:
[root@foo test]# ./test foo
Hostname: foo.bar
I don't think there is an actual reason to iterate through all of the
/etc/hosts and first match can be returned instead. Following patch
should in my opinion fix this.
diff --git a/src/network/lookup_name.c b/src/network/lookup_name.c
index c93263a9..da8db9d4 100644
--- a/src/network/lookup_name.c
+++ b/src/network/lookup_name.c
@@ -87,7 +87,10 @@ static int name_from_hosts(struct address buf[static MAXADDRS], char canon[stati
for (; *p && isspace(*p); p++);
for (z=p; *z && !isspace(*z); z++);
*z = 0;
- if (is_valid_hostname(p)) memcpy(canon, p, z-p+1);
+ if (is_valid_hostname(p)) {
+ memcpy(canon, p, z-p+1);
+ break;
+ }
}
__fclose_ca(f);
return cnt ? cnt : badfam;
While this is admittedly edge case that most users will not run into, I
still think it would be nice to behave the same way as glibc does on
this one. And as a bonus, it will be *tiny* bit faster, since there
would not be any need to iterate rest of the /etc/hosts file.
Thank you for considering this,
W.
--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2020-03-13 21:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 21:46 Wolf [this message]
2020-03-13 22:16 ` Rich Felker
2020-03-13 23:43 ` Wolf
2020-04-13 23:18 ` Wolf
2020-04-15 8:31 ` Natanael Copa
2020-04-15 16:03 ` Rich Felker
2020-03-14 8:24 ` Florian Weimer
2020-03-14 14:54 ` Rich Felker
2020-03-14 16:31 ` Jeffrey Walton
2020-04-17 18:42 ` Rich Felker
2020-04-17 18:46 ` Rich Felker
2020-04-26 0:15 ` Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313214648.2qqr5utzyqy5ewsu@wolfsden.cz \
--to=wolf@wolfsden.cz \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).