mailing list of musl libc
 help / color / Atom feed
* [musl] [PATCH] ldso: remove redundant switch case for REL_NONE
@ 2020-03-08 18:10 Fangrui Song
  2020-03-20 19:46 ` Rich Felker
  0 siblings, 1 reply; 2+ messages in thread
From: Fangrui Song @ 2020-03-08 18:10 UTC (permalink / raw)
  To: musl

as a result of commit b6a6cd703ffefa6352249fb01f4da28d85d17306,
the REL_NONE case is now redundant.
---
 ldso/dynlink.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/ldso/dynlink.c b/ldso/dynlink.c
index afec985a..6468f203 100644
--- a/ldso/dynlink.c
+++ b/ldso/dynlink.c
@@ -415,8 +415,6 @@ static void do_relocs(struct dso *dso, size_t *rel, size_t rel_size, size_t stri
 		}
 
 		switch(type) {
-		case REL_NONE:
-			break;
 		case REL_OFFSET:
 			addend -= (size_t)reloc_addr;
 		case REL_SYMBOLIC:
-- 
2.25.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [musl] [PATCH] ldso: remove redundant switch case for REL_NONE
  2020-03-08 18:10 [musl] [PATCH] ldso: remove redundant switch case for REL_NONE Fangrui Song
@ 2020-03-20 19:46 ` Rich Felker
  0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2020-03-20 19:46 UTC (permalink / raw)
  To: musl

On Sun, Mar 08, 2020 at 11:10:32AM -0700, Fangrui Song wrote:
> as a result of commit b6a6cd703ffefa6352249fb01f4da28d85d17306,
> the REL_NONE case is now redundant.
> ---
>  ldso/dynlink.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/ldso/dynlink.c b/ldso/dynlink.c
> index afec985a..6468f203 100644
> --- a/ldso/dynlink.c
> +++ b/ldso/dynlink.c
> @@ -415,8 +415,6 @@ static void do_relocs(struct dso *dso, size_t *rel, size_t rel_size, size_t stri
>  		}
>  
>  		switch(type) {
> -		case REL_NONE:
> -			break;
>  		case REL_OFFSET:
>  			addend -= (size_t)reloc_addr;
>  		case REL_SYMBOLIC:
> -- 
> 2.25.1

Thanks, applying.

Rich

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-08 18:10 [musl] [PATCH] ldso: remove redundant switch case for REL_NONE Fangrui Song
2020-03-20 19:46 ` Rich Felker

mailing list of musl libc

Archives are clonable: git clone --mirror http://inbox.vuxu.org/musl

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.musl


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git