From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RDNS_NONE,
	SPF_PASS autolearn=ham autolearn_force=no version=3.4.2
Received: (qmail 27976 invoked from network); 20 Mar 2020 19:46:35 -0000
Received-SPF:  pass (mother.openwall.net: domain of lists.openwall.com
  designates 195.42.179.200 as permitted sender)
  receiver=inbox.vuxu.org; client-ip=195.42.179.200
  envelope-from=<musl-return-15584-ml=inbox.vuxu.org@lists.openwall.com>
Received: from unknown (HELO mother.openwall.net) (195.42.179.200)
  by inbox.vuxu.org with ESMTP; 20 Mar 2020 19:46:35 -0000
Received: (qmail 9275 invoked by uid 550); 20 Mar 2020 19:46:32 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 9257 invoked from network); 20 Mar 2020 19:46:32 -0000
Date: Fri, 20 Mar 2020 15:46:20 -0400
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Message-ID: <20200320194620.GD11469@brightrain.aerifal.cx>
References: <20200308181032.jpojp6bttzwhc4k2@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200308181032.jpojp6bttzwhc4k2@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [musl] [PATCH] ldso: remove redundant switch case for REL_NONE

On Sun, Mar 08, 2020 at 11:10:32AM -0700, Fangrui Song wrote:
> as a result of commit b6a6cd703ffefa6352249fb01f4da28d85d17306,
> the REL_NONE case is now redundant.
> ---
>  ldso/dynlink.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/ldso/dynlink.c b/ldso/dynlink.c
> index afec985a..6468f203 100644
> --- a/ldso/dynlink.c
> +++ b/ldso/dynlink.c
> @@ -415,8 +415,6 @@ static void do_relocs(struct dso *dso, size_t *rel, size_t rel_size, size_t stri
>  		}
>  
>  		switch(type) {
> -		case REL_NONE:
> -			break;
>  		case REL_OFFSET:
>  			addend -= (size_t)reloc_addr;
>  		case REL_SYMBOLIC:
> -- 
> 2.25.1

Thanks, applying.

Rich