From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RDNS_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: (qmail 23421 invoked from network); 21 Mar 2020 17:07:01 -0000 Received-SPF: pass (mother.openwall.net: domain of lists.openwall.com designates 195.42.179.200 as permitted sender) receiver=inbox.vuxu.org; client-ip=195.42.179.200 envelope-from= Received: from unknown (HELO mother.openwall.net) (195.42.179.200) by inbox.vuxu.org with ESMTP; 21 Mar 2020 17:07:01 -0000 Received: (qmail 23871 invoked by uid 550); 21 Mar 2020 17:06:57 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 23852 invoked from network); 21 Mar 2020 17:06:56 -0000 Date: Sat, 21 Mar 2020 13:06:43 -0400 From: Rich Felker To: musl@lists.openwall.com Message-ID: <20200321170643.GI11469@brightrain.aerifal.cx> References: <20200106084030.5259-1-amonakov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200106084030.5259-1-amonakov@ispras.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] [PATCH] math: move more x86-family fabs functions to C On Mon, Jan 06, 2020 at 11:40:30AM +0300, Alexander Monakov wrote: > diff --git a/src/math/i386/fabsf.c b/src/math/i386/fabsf.c > new file mode 100644 > index 00000000..d07be321 > --- /dev/null > +++ b/src/math/i386/fabsf.c > @@ -0,0 +1,7 @@ > +#include > + > +float fabs(float x) ^^^^ > +{ > + __asm__ ("fabs" : "+t"(x)); > + return x; > +} Should be fabsf -- found while smoketesting. Otherwise things built ok for i386. Will followup with more results soon. Rich