From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RDNS_NONE,
	SPF_PASS autolearn=ham autolearn_force=no version=3.4.2
Received: (qmail 19793 invoked from network); 22 Mar 2020 15:06:13 -0000
Received-SPF:  pass (mother.openwall.net: domain of lists.openwall.com
  designates 195.42.179.200 as permitted sender)
  receiver=inbox.vuxu.org; client-ip=195.42.179.200
  envelope-from=<musl-return-15595-ml=inbox.vuxu.org@lists.openwall.com>
Received: from unknown (HELO mother.openwall.net) (195.42.179.200)
  by inbox.vuxu.org with ESMTP; 22 Mar 2020 15:06:13 -0000
Received: (qmail 28045 invoked by uid 550); 22 Mar 2020 15:06:10 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 28027 invoked from network); 22 Mar 2020 15:06:09 -0000
Date: Sun, 22 Mar 2020 11:05:57 -0400
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Message-ID: <20200322150557.GN11469@brightrain.aerifal.cx>
References: <20200129112007.17575-1-soeren+git@soeren-tempel.net>
 <2NSST1D2CU3ZF.2X6OJSUS9Q20S@8pit.net>
 <36221X68MA893.2BYWBI9CL1WMJ@8pit.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <36221X68MA893.2BYWBI9CL1WMJ@8pit.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [musl] [PATCH v2] cuserid: support invocation with a NULL
 pointer argument

On Sun, Mar 22, 2020 at 10:51:56AM +0100, Sören Tempel wrote:
> Sören Tempel <soeren@soeren-tempel.net> wrote:
> > From my personal Alpine Linux packaging perspective: I would prefer
> > either removing the function entirely or supporting the invocation with
> > a NULL pointer argument. Currently, apps using this with a NULL pointer
> > (e.g. cdparanoia) will crash at runtime which makes it more difficult to
> > identify them. If the function would be removed entirely we would be
> > able to detect, during compilation, which apps use it and patch them
> > accordingly.
> 
> Ping.

Thanks. I'm trying to catch up on patches and I just confirmed your
research, so I think the patch is correct. I'll apply soon.

Rich