mailing list of musl libc
 help / color / mirror / code / Atom feed
* [musl] [Bug] Do not ignore membarrier return code
@ 2020-03-23 16:10 Julio Guerra
  2020-03-23 16:38 ` Rich Felker
  0 siblings, 1 reply; 8+ messages in thread
From: Julio Guerra @ 2020-03-23 16:10 UTC (permalink / raw)
  To: musl; +Cc: Vladimir de Turckheim

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

Hello,

The implementation of dlopen() uses membarrier() (
https://git.musl-libc.org/cgit/musl/tree/ldso/dynlink.c#n1579) while
currently forbidden by the default docker seccomp profile.

I perfectly understand that it's on docker's end and I suggested them to
add it in this PR <https://github.com/moby/moby/pull/40731> but such a
critical syscall shouldn't be silently ignored. And it for example leads to
random segfaults on nodejs. I also saw opened qemu issues related to
membarrier + alpine.

dlopen() should therefore fail when membarrier fails (ie. in this case
when __membarrier(MEMBARRIER_CMD_PRIVATE_EXPEDITED,
0) != 0).

Happy to provide the patch if agreed!
All the best,
Julio Guerra

[-- Attachment #2: Type: text/html, Size: 1764 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-03-24 17:42 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-23 16:10 [musl] [Bug] Do not ignore membarrier return code Julio Guerra
2020-03-23 16:38 ` Rich Felker
2020-03-24 13:20   ` Julio Guerra
2020-03-24 13:53     ` Rich Felker
2020-03-24 13:53     ` Julio Guerra
2020-03-24 14:01       ` Rich Felker
2020-03-24 16:08         ` A. Wilcox
2020-03-24 17:42           ` Rich Felker

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).