From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RDNS_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: (qmail 31532 invoked from network); 28 Mar 2020 16:40:08 -0000 Received-SPF: pass (mother.openwall.net: domain of lists.openwall.com designates 195.42.179.200 as permitted sender) receiver=inbox.vuxu.org; client-ip=195.42.179.200 envelope-from= Received: from unknown (HELO mother.openwall.net) (195.42.179.200) by inbox.vuxu.org with ESMTP; 28 Mar 2020 16:40:08 -0000 Received: (qmail 31745 invoked by uid 550); 28 Mar 2020 16:40:06 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 30688 invoked from network); 28 Mar 2020 16:40:05 -0000 Date: Sat, 28 Mar 2020 17:39:54 +0100 From: Szabolcs Nagy To: musl@lists.openwall.com Message-ID: <20200328163954.GV14278@port70.net> Mail-Followup-To: musl@lists.openwall.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="g7w8+K/95kPelPD2" Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Subject: [musl] [PATCH v2] fix glibc ABI compat --g7w8+K/95kPelPD2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline v2: export __strftime_l only, not the resolv symbols --g7w8+K/95kPelPD2 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-fix-glibc-ABI-compat.patch" >From 6304ba52b696c781668d792aa089d51283e9e5d3 Mon Sep 17 00:00:00 2001 From: Szabolcs Nagy Date: Sat, 28 Mar 2020 11:11:32 +0000 Subject: [PATCH v2] fix glibc ABI compat commit 0676c3a34c7bf12b33f8f5efb92476f4ffc7f20e made various internal symbols hidden, but at least __strftime_l is useful for glibc ABI compatibility since it is used by glibc linked libstdc++ so make it avilable again to avoid regression. the following symbols are hidden in musl, but exported in glibc and present in current glibc public headers too: __dn_expand __res_mkquery __res_send __stpcpy __stpncpy glibc resolv symbols are not completely covered in musl and making a small subset available does not help much. it seems there never was a redirection to __stpcpy or __stpncpy in glibc headers so they are unlikely to be used. --- src/include/time.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/include/time.h b/src/include/time.h index cbabde47..4f94bc39 100644 --- a/src/include/time.h +++ b/src/include/time.h @@ -10,6 +10,6 @@ hidden char *__asctime_r(const struct tm *, char *); hidden struct tm *__gmtime_r(const time_t *restrict, struct tm *restrict); hidden struct tm *__localtime_r(const time_t *restrict, struct tm *restrict); -hidden size_t __strftime_l(char *restrict, size_t, const char *restrict, const struct tm *restrict, locale_t); +size_t __strftime_l(char *restrict, size_t, const char *restrict, const struct tm *restrict, locale_t); #endif -- 2.24.1 --g7w8+K/95kPelPD2--