* [musl] [PATCH] fix the symbol value for a dynamic relocation referencing a SHN_ABS symbol
@ 2020-04-03 6:28 Fangrui Song
0 siblings, 0 replies; only message in thread
From: Fangrui Song @ 2020-04-03 6:28 UTC (permalink / raw)
To: musl
fixes the example at https://sourceware.org/bugzilla/show_bug.cgi?id=19818#c3
the glibc bug also mentions dladdr() but that change seems more disruptive and
i am now sure whether/how that should be fixed.
---
ldso/dynlink.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ldso/dynlink.c b/ldso/dynlink.c
index afec985a..6f4b50c9 100644
--- a/ldso/dynlink.c
+++ b/ldso/dynlink.c
@@ -403,7 +403,10 @@ static void do_relocs(struct dso *dso, size_t *rel, size_t rel_size, size_t stri
def.dso = dso;
}
- sym_val = def.sym ? (size_t)laddr(def.dso, def.sym->st_value) : 0;
+ sym_val = def.sym
+ ? def.sym->st_shndx == SHN_ABS ? def.sym->st_value
+ : (size_t)laddr(def.dso, def.sym->st_value)
+ : 0;
tls_val = def.sym ? def.sym->st_value : 0;
if ((type == REL_TPOFF || type == REL_TPOFF_NEG)
--
2.26.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-03 6:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-03 6:28 [musl] [PATCH] fix the symbol value for a dynamic relocation referencing a SHN_ABS symbol Fangrui Song
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).