mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: "liheng (P)" <liheng40@huawei.com>
Cc: Florian Weimer <fw@deneb.enyo.de>, Rich Felker <dalias@libc.org>,
	"musl@lists.openwall.com" <musl@lists.openwall.com>,
	"Xiangrui (Euler)" <rui.xiang@huawei.com>,
	Lizefan <lizefan@huawei.com>
Subject: Re: [musl] regex Back reference matching result not same as glibc and tre.
Date: Sat, 18 Apr 2020 13:13:09 +0200	[thread overview]
Message-ID: <20200418111309.GD23945@port70.net> (raw)
In-Reply-To: <6D612B6AC5DCDA4580AF97B1068118AD2DC524@DGGEML501-MBX.china.huawei.com>

* liheng (P) <liheng40@huawei.com> [2020-04-18 11:07:20 +0000]:
> static const char pat[] = "\\(.?\\).?\\1";
> string: "aba";

? is not special in bre

it should be \{0,1\} (i think we support \? as an extension,
but unescaped ? only matches literal ?). try one of

static const char pat[] = "\\(.\\{0,1\\}\\).\\{0,1\\}\\1";
static const char pat[] = "\\(.\\?\\).\\?\\1";

> 
> I tested this pattern by my test case just now.
> 
> musl:
> # ./test
> regexec failed
> test regex failed
> 
> glibc:
> # ./test
> Invalid back reference
> test regex failed
> 
> tre:
> # ./test
> Invalid back reference
> test regex failed
> 
> -----Original Message-----
> From: Florian Weimer [mailto:fw@deneb.enyo.de] 
> Sent: Saturday, April 18, 2020 6:29 PM
> To: liheng (P) <liheng40@huawei.com>
> Cc: Rich Felker <dalias@libc.org>; musl@lists.openwall.com; Xiangrui (Euler) <rui.xiang@huawei.com>; Lizefan <lizefan@huawei.com>
> Subject: Re: [musl] regex Back reference matching result not same as glibc and tre.
> 
> * liheng:
> 
> > static const char pat[] = "(.?).?\\1";
> 
> > This commit reminds me that if i want to use back reference i should 
> > not to tag REG_EXTENDED, but this test case matching still failed.
> 
> 
> Did you change the expression to this for the basic regular expression test?
> 
> static const char pat[] = "\\(.?\\).?\\1";

  reply	other threads:[~2020-04-18 11:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-18  8:44 liheng (P)
2020-04-18 10:28 ` Florian Weimer
2020-04-18 11:07   ` liheng (P)
2020-04-18 11:13     ` Szabolcs Nagy [this message]
2020-04-18 11:37       ` liheng (P)
2020-04-18 14:07         ` Szabolcs Nagy
2020-04-19 12:26           ` liheng (P)
2020-04-19 13:10             ` Florian Weimer
2020-04-20  1:26             ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200418111309.GD23945@port70.net \
    --to=nsz@port70.net \
    --cc=dalias@libc.org \
    --cc=fw@deneb.enyo.de \
    --cc=liheng40@huawei.com \
    --cc=lizefan@huawei.com \
    --cc=musl@lists.openwall.com \
    --cc=rui.xiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).