From: Markus Wichmann <nullplan@gmx.net>
To: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] fix coredump when sched_rr_get_interval parameter ts is NULL
Date: Fri, 8 May 2020 17:47:37 +0200 [thread overview]
Message-ID: <20200508154737.GA25182@voyager> (raw)
In-Reply-To: <2f7471a2f0ac45f6bfc48191e16b25ec@huawei.com>
On Fri, May 08, 2020 at 02:46:56PM +0000, zhuyan (M) wrote:
> In function sched_rr_get_interval, there is a risk of null pointer reference. On line 12, when ts is NULL, dereferencing the null pointer will cause the program coredump.
>
> Therefore, it must ensure that ts is not empty before use.
>
Is calling this function with a NULL pointer sensible? The manpage
certainly doesn't say so. Usually policy in musl is to not fix
application bugs, but to dereference pointers without NULL pointer check
unless there is an explicit requirement in the relevant standards that a
NULL pointer be accepted.
Ciao,
Markus
next prev parent reply other threads:[~2020-05-08 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200508143931.5165-1-zhuyan34@huawei.com>
2020-05-08 14:46 ` zhuyan (M)
2020-05-08 15:47 ` Markus Wichmann [this message]
2020-05-08 18:45 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508154737.GA25182@voyager \
--to=nullplan@gmx.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).