mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: Norbert Lange <nolange79@gmail.com>
Cc: musl@lists.openwall.com
Subject: Re: [musl] Mark stack as non-executable in asm
Date: Wed, 10 Jun 2020 12:31:02 +0200	[thread overview]
Message-ID: <20200610103102.GF871552@port70.net> (raw)
In-Reply-To: <CADYdroN+CxoPihWQtAR7rOM9A9cDtUr9a9RzP4SrG7d6G1gv0A@mail.gmail.com>

* Norbert Lange <nolange79@gmail.com> [2020-06-10 11:24:04 +0200]:
> I did borrow some assembler files to avoid having to link against
> (any) libc. That was for building a DSO, ultimately loaded via glibc.
> The effect was that glibc did change the protection of all stacks to
> be executable.
> 
> Would you consider adding the line [1]
> .section        .note.GNU-stack, "", %progbits
> to assembly files?
> 
> I know this is not a musl bug, and I can easily add the lines myself.

musl build system (just like other libcs i know of)
pass -noexecstack to the assembler so if you build
the asm files as part of libc the object files should
have the marking, if you build outside of libc i
think it's your responsibility to add the note
(either to the asm or via the -Wa,-noexecstack flag)

readelf -lW libfoo.so | grep GNU_STACK

is one way to verify that everything has the note.

> 
> regards, Norbert
> 
> [1] - https://wiki.ubuntu.com/SecurityTeam/Roadmap/ExecutableStacks

  reply	other threads:[~2020-06-10 10:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10  9:24 Norbert Lange
2020-06-10 10:31 ` Szabolcs Nagy [this message]
2020-06-10 10:39   ` Jeffrey Walton
2020-06-10 10:43   ` Norbert Lange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200610103102.GF871552@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    --cc=nolange79@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).