From: Szabolcs Nagy <nsz@port70.net>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [musl] mallocng switchover - opportunity to test
Date: Fri, 12 Jun 2020 19:42:00 +0200 [thread overview]
Message-ID: <20200612174200.GA2048759@port70.net> (raw)
In-Reply-To: <20200611200530.GQ1079@brightrain.aerifal.cx>
* Rich Felker <dalias@libc.org> [2020-06-11 16:05:30 -0400]:
> On Wed, Jun 10, 2020 at 10:33:06AM +0200, Szabolcs Nagy wrote:
> > > > I'm not sure about this, and how it interacts with our definition of
> > > > posix_memalign and memalign in terms of aligned_alloc.
> > >
> > > What do you think of this proposal:
> > >
> > > Have ldso track both whether malloc was replaced and whether
> > > aligned_alloc was replaced. If malloc was replaced but aligned_alloc
> > > wasn't, aligned_alloc fails with ENOMEM. If both were replaced and our
> > > internal aligned_alloc still gets called, assume some sort of wrapping
> > > is going on and allow it to proceed.
> > >
> > > With mallocng, this is "safe" against misuse in the sense that it will
> > > trap rather than corrupting memory if the contract is violated.
> >
> > sounds good to me.
>
> As of commit 1fc67fc117f9d25d240d46bbef78ebccacec7097 it should behave
> as proposed here. Does this look/behave like what you expected?
yes this works for me, thanks.
next prev parent reply other threads:[~2020-06-12 17:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 3:50 Rich Felker
2020-06-09 11:09 ` Szabolcs Nagy
2020-06-09 20:08 ` Rich Felker
2020-06-10 0:58 ` Rich Felker
2020-06-10 8:33 ` Szabolcs Nagy
2020-06-11 20:05 ` Rich Felker
2020-06-12 17:42 ` Szabolcs Nagy [this message]
2020-06-10 9:19 ` Szabolcs Nagy
2020-06-10 16:41 ` Rich Felker
2020-06-11 3:49 ` Rich Felker
2020-06-11 4:33 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612174200.GA2048759@port70.net \
--to=nsz@port70.net \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).