From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [musl] Potential deadlock in pthread_kill()
Date: Tue, 30 Jun 2020 15:54:10 -0400 [thread overview]
Message-ID: <20200630195409.GH6430@brightrain.aerifal.cx> (raw)
In-Reply-To: <477cc243-b950-3363-e9f4-4c8a203b6bea@samersoff.net>
On Tue, Jun 30, 2020 at 10:28:50PM +0300, Dmitry Samersoff wrote:
> Hello all,
>
> Does it make sense to trylock and immediately return ESRCH if
> pthread_kill is already in progress?
No, ESRCH is not a valid result for this condition. Moreover killlock
being taken does not tell you that pthread_kill is already in progress
targeting the same thread, just that something that needs the kernel
tid to be valid (kill, cancel, or scheduling changes) or that needs to
change its validity (exiting) is in progress.
Note that for fixing this issue, it won't suffice just to make
pthread_kill block signals. The other places that use the killlock
also need to block signals, to make the lock fully AS-safe.
Rich
next prev parent reply other threads:[~2020-06-30 19:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 4:19 Hydro Flask
2020-06-30 4:43 ` Rich Felker
2020-06-30 6:19 ` Hydro Flask
2020-06-30 9:26 ` Rich Felker
2020-06-30 14:58 ` Markus Wichmann
2020-06-30 16:28 ` Hydro Flask
2020-06-30 19:28 ` Dmitry Samersoff
2020-06-30 19:54 ` Rich Felker [this message]
2020-06-30 21:00 ` Hydro Flask
2020-07-06 22:00 ` Rich Felker
2020-07-06 22:14 ` Hydro Flask
2020-07-06 22:22 ` Rich Felker
2020-07-06 22:37 ` Hydro Flask
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630195409.GH6430@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).