mailing list of musl libc
 help / color / Atom feed
* [musl] [PATCH] vfscanf: fix use of uninitialized variable
@ 2020-07-01 13:12 Julien Ramseier
  2020-07-06 22:00 ` Rich Felker
  0 siblings, 1 reply; 2+ messages in thread
From: Julien Ramseier @ 2020-07-01 13:12 UTC (permalink / raw)
  To: musl

vfscanf() may use the variable 'alloc' uninitialized when taking the branch
introduced by recent commit b287cd745c2243f8e5114331763a5a9813b5f6ee.

Spotted by clang:

../lib/libc/src/stdio/vfscanf.c:80:6: warning: variable 'alloc' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
        if (!f->rpos) goto input_fail;
            ^~~~~~~~
../lib/libc/src/stdio/vfscanf.c:330:7: note: uninitialized use occurs here
                if (alloc) {
                    ^~~~~

---
 src/stdio/vfscanf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/stdio/vfscanf.c b/src/stdio/vfscanf.c
index b5ebc16e..b78a374d 100644
--- a/src/stdio/vfscanf.c
+++ b/src/stdio/vfscanf.c
@@ -57,7 +57,7 @@ int vfscanf(FILE *restrict f, const char *restrict fmt, va_list ap)
 {
 	int width;
 	int size;
-	int alloc;
+	int alloc = 0;
 	int base;
 	const unsigned char *p;
 	int c, t;
-- 
2.23.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [musl] [PATCH] vfscanf: fix use of uninitialized variable
  2020-07-01 13:12 [musl] [PATCH] vfscanf: fix use of uninitialized variable Julien Ramseier
@ 2020-07-06 22:00 ` Rich Felker
  0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2020-07-06 22:00 UTC (permalink / raw)
  To: musl

On Wed, Jul 01, 2020 at 03:12:14PM +0200, Julien Ramseier wrote:
> vfscanf() may use the variable 'alloc' uninitialized when taking the branch
> introduced by recent commit b287cd745c2243f8e5114331763a5a9813b5f6ee.
> 
> Spotted by clang:
> 
> .../lib/libc/src/stdio/vfscanf.c:80:6: warning: variable 'alloc' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
>         if (!f->rpos) goto input_fail;
>             ^~~~~~~~
> .../lib/libc/src/stdio/vfscanf.c:330:7: note: uninitialized use occurs here
>                 if (alloc) {
>                     ^~~~~
> 
> ---
>  src/stdio/vfscanf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/stdio/vfscanf.c b/src/stdio/vfscanf.c
> index b5ebc16e..b78a374d 100644
> --- a/src/stdio/vfscanf.c
> +++ b/src/stdio/vfscanf.c
> @@ -57,7 +57,7 @@ int vfscanf(FILE *restrict f, const char *restrict fmt, va_list ap)
>  {
>  	int width;
>  	int size;
> -	int alloc;
> +	int alloc = 0;
>  	int base;
>  	const unsigned char *p;
>  	int c, t;
> -- 
> 2.23.0

Thanks, applied.

Rich

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01 13:12 [musl] [PATCH] vfscanf: fix use of uninitialized variable Julien Ramseier
2020-07-06 22:00 ` Rich Felker

mailing list of musl libc

Archives are clonable: git clone --mirror http://inbox.vuxu.org/musl

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.musl


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git