From: Szabolcs Nagy <nsz@port70.net>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [musl] Release prep for 1.2.1, and afterwards
Date: Tue, 7 Jul 2020 20:20:44 +0200 [thread overview]
Message-ID: <20200707182044.GK2048759@port70.net> (raw)
In-Reply-To: <20200707172257.GO6430@brightrain.aerifal.cx>
* Rich Felker <dalias@libc.org> [2020-07-07 13:22:57 -0400]:
> On Tue, Jul 07, 2020 at 05:00:20PM +0200, Szabolcs Nagy wrote:
> > * Rich Felker <dalias@libc.org> [2020-07-06 18:12:43 -0400]:
> > > I think you saw already, but just to make it clear on the list too,
> > > it's upstream now. I'm open to further improvements like doing
> > > memmove (either as a separate copy of the full implementation or some
> > > minimal branch-to-__memcpy_fwd approach) but I think what's already
> > > there is sufficient to solve the main practical performance issues
> > > users were hitting that made aarch64 look bad in relation to x86_64.
> > >
> > > I'd still like to revisit the topic of minimizing the per-arch code
> > > needed for this so that all archs can benefit from the basic logic,
> > > too.
> >
> > thanks.
> >
> > note that the code has some internal .p2align
> > directives that assume the entry is aligned to
> > some large alignment (.p2align 6 in orig code)
> >
> > i think it would be better to keep the entry
> > aligned (but i don't know if it makes a big
> > difference on some existing core, it's more
> > for consistency with upstream).
> >
> > musl normally does not align function entries
> > but for a few select functions it is probably
> > not too much overhead?
>
> I was under the impression that any .p2align N in the section
> inherently aligns the whole section as if it started with .p2align N,
> in which case not writing it explicitly just avoids redundancy and
> makes sure you don't actually have an initial alignment that's larger
> than any alignment actually wanted later. Is this incorrect?
>
> (To be incorrect I think it would have to do some fancy
> elastic-section-contents hack, but maybe aarch64 ELF object ABI has
> that..?)
ah you are right, then everything is fine i guess.
next prev parent reply other threads:[~2020-07-07 18:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 20:42 Rich Felker
2020-06-24 22:39 ` Jeffrey Walton
2020-06-25 8:15 ` Szabolcs Nagy
2020-06-25 15:39 ` Rich Felker
2020-06-25 17:31 ` Szabolcs Nagy
2020-06-25 20:50 ` Rich Felker
2020-06-25 21:15 ` Rich Felker
2020-06-26 1:20 ` Rich Felker
2020-06-26 8:40 ` Szabolcs Nagy
2020-07-06 22:12 ` Rich Felker
2020-07-07 15:00 ` Szabolcs Nagy
2020-07-07 17:22 ` Rich Felker
2020-07-07 18:20 ` Szabolcs Nagy [this message]
2020-06-25 21:43 ` Andre McCurdy
2020-06-25 21:51 ` Rich Felker
2020-06-25 22:03 ` Andre McCurdy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707182044.GK2048759@port70.net \
--to=nsz@port70.net \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).