From: Jens Gustedt <jens.gustedt@inria.fr>
To: musl@lists.openwall.com
Subject: [musl] direct coding of asctime_r
Date: Sun, 23 Aug 2020 10:24:39 +0200 [thread overview]
Message-ID: <20200823102439.2bbaffb5@inria.fr> (raw)
[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]
Hello,
I don't know if you guys noticed, but sometime ago we voted some of
the ..._r functions from <time.h> into the C standard, just to then
discover that POSIX has deprecated the whole set of functions and
proposes to replace them by `strftime`.
One of the arguments to keep them, was that `asctime_r` does not need
access to locale and has a fixed format, and so can be implemented
with a much smaller footprint.
Looking into musl I found that the current implementation is basically
doing verbatim what the C standard says, namely uses `snprintf` under
the hood to do the formatting. This has obviously the disadvantage
that this drags the whole infrastructure that is needed for `snprintf`
into the executable.
Making some tests, I found that coding `asctime_r` straight forward
with byte-copying has it shave off about 10k from the final
executable.
Would it be interesting for musl to change to such an implementation?
Shall I prepare a patch to do so?
Jens
--
:: INRIA Nancy Grand Est ::: Camus ::::::: ICube/ICPS :::
:: ::::::::::::::: office Strasbourg : +33 368854536 ::
:: :::::::::::::::::::::: gsm France : +33 651400183 ::
:: ::::::::::::::: gsm international : +49 15737185122 ::
:: http://icube-icps.unistra.fr/index.php/Jens_Gustedt ::
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next reply other threads:[~2020-08-23 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 8:24 Jens Gustedt [this message]
2020-08-23 9:33 ` Alexander Monakov
2020-08-23 9:56 ` Jens Gustedt
2020-08-23 11:08 ` Alexander Monakov
2020-08-24 16:14 ` Rich Felker
2020-08-27 9:27 ` Jens Gustedt
2020-08-27 14:03 ` Rich Felker
2020-08-27 14:24 ` Jens Gustedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200823102439.2bbaffb5@inria.fr \
--to=jens.gustedt@inria.fr \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).