From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [musl] Bug in mmap_fixed()
Date: Wed, 16 Sep 2020 08:04:39 -0400 [thread overview]
Message-ID: <20200916120438.GS3265@brightrain.aerifal.cx> (raw)
In-Reply-To: <edf21bae-73a9-f082-2cf2-d90b5e4e03bf@landley.net>
On Wed, Sep 16, 2020 at 12:15:23AM -0500, Rob Landley wrote:
> On 9/5/20 1:44 AM, Markus Wichmann wrote:
> > On Fri, Sep 04, 2020 at 11:41:54PM -0400, Rich Felker wrote:
> >> When I saw your report, I thought this code all ran with signals
> >> blocked, and actually had to check to see that this isn't the case.
> >
> > In that case, making an exception for EINTR would be even weirder.
> >
> >> The code hsould be fixed, and EINTR handling should probably be left
> >> in-place, just without the wrong pointer-advance logic.
> >>
> >
> > See attached. Untested, obviously, since I lack a Super-H processor and
> > an NFS server,
>
> Coldfire is also nommu and musl has had m68k support for years, is there no
> coldfire target? (That's been supported by qemu longer than proper m68k.)
>
> Rob
>
> P.S. This patches out the broken fork() on nommu sh2, and fixes the sh2 native
> toolchain build:
>
> https://github.com/landley/toybox/blob/master/scripts/mcm-buildall.sh#L130
You have been told again and again this is not a bug, and your patch
is ABI breakage. There is no "nommu version of musl". There is a
common ABI that runs on mmuful and nommu machines and whether fork can
succeed or not is a runtime property.
Rich
next prev parent reply other threads:[~2020-09-16 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 19:52 Markus Wichmann
2020-09-05 3:41 ` Rich Felker
2020-09-05 6:44 ` Markus Wichmann
2020-09-16 5:15 ` Rob Landley
2020-09-16 12:04 ` Rich Felker [this message]
2020-09-16 14:20 ` Markus Wichmann
2020-09-05 8:39 ` Stefan O'Rear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916120438.GS3265@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).