From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 21246 invoked from network); 16 Sep 2020 12:04:55 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 16 Sep 2020 12:04:55 -0000 Received: (qmail 9840 invoked by uid 550); 16 Sep 2020 12:04:52 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 9819 invoked from network); 16 Sep 2020 12:04:52 -0000 Date: Wed, 16 Sep 2020 08:04:39 -0400 From: Rich Felker To: musl@lists.openwall.com Message-ID: <20200916120438.GS3265@brightrain.aerifal.cx> References: <20200904195251.GA2139@voyager> <20200905034153.GI3265@brightrain.aerifal.cx> <20200905064419.GB2139@voyager> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] Bug in mmap_fixed() On Wed, Sep 16, 2020 at 12:15:23AM -0500, Rob Landley wrote: > On 9/5/20 1:44 AM, Markus Wichmann wrote: > > On Fri, Sep 04, 2020 at 11:41:54PM -0400, Rich Felker wrote: > >> When I saw your report, I thought this code all ran with signals > >> blocked, and actually had to check to see that this isn't the case. > > > > In that case, making an exception for EINTR would be even weirder. > > > >> The code hsould be fixed, and EINTR handling should probably be left > >> in-place, just without the wrong pointer-advance logic. > >> > > > > See attached. Untested, obviously, since I lack a Super-H processor and > > an NFS server, > > Coldfire is also nommu and musl has had m68k support for years, is there no > coldfire target? (That's been supported by qemu longer than proper m68k.) > > Rob > > P.S. This patches out the broken fork() on nommu sh2, and fixes the sh2 native > toolchain build: > > https://github.com/landley/toybox/blob/master/scripts/mcm-buildall.sh#L130 You have been told again and again this is not a bug, and your patch is ABI breakage. There is no "nommu version of musl". There is a common ABI that runs on mmuful and nommu machines and whether fork can succeed or not is a runtime property. Rich