From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 27401 invoked from network); 1 Oct 2020 20:27:23 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 1 Oct 2020 20:27:23 -0000 Received: (qmail 18053 invoked by uid 550); 1 Oct 2020 20:27:18 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 18023 invoked from network); 1 Oct 2020 20:27:17 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=EyAWOpM2Pk1ZBrqrrdSu1rvJL+knSPmewqYJM3X+YZM=; b=F/S72vRwMmvTJ8PZszfC8/s9iZSqKMIp6JFsHp/36W7P7WL0kTOBZl0wLTfDfoL/wi 8WD7usifl3QPwN4x5b/SV0VnWj9SY5ac7BhI++csXd8RMaXHTxRF9JIq/MWsDpiNCnN5 9Gf6dpGxpQCixE0zna1HpZ8uRyk0ztae+mSIFEmaqiafuJuvV4FA2Q68PbwDf9Qi9O/c gctjBXDPm2/SyD7NBPid3xT9mnjxpeDE+FQPHlINiy0HcSKPnsYzrbBxx13xdw3U97m3 N5b2HUh3OFxpOX9VSvp4c/E4kn+rpH1V/TNU62j+tfCK8O0UIDCrIyZKSSnRsAHR/N+n Tn0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=EyAWOpM2Pk1ZBrqrrdSu1rvJL+knSPmewqYJM3X+YZM=; b=qdWL9Z07rTvqrkkALINaS0tnGAcQDWvO9rDbx/YxLgx2LT4GZ2FcnOJOYiikU9j6dK mesnzp6qhtoigCzKQJtv+bicImDJPXwsVEtIsiL3qdX7zvZX6TOEVTgRsuXhu/S2sdFZ o8/GXQM8Zi5xgWDbdty/6UFpoTnkIozxTTtTEAQ3oOnXe5XMQu6nJ4NZPgyoqd8K7ztB gnjdc+nnIsX0lK3T8MFQUDWSz+fUkSZ/wY783Jw+/L5rH9CAgYkyhHZlnzwp2a0IMT4E /PBci05ZbfJrd297QriEZFqeaWjJ26fMbEgndP3Uzoq3dZYPzekdYL2baRl5AgYW6cW9 Ghkg== X-Gm-Message-State: AOAM532XrxbIvfWhRoGBGv3G6bktQcq235CE01VocBAjm88pTo08qq/e igNFtG1pgmm3z6lSlxXqUwM= X-Google-Smtp-Source: ABdhPJxr5dY8ODx0EjH/xdbyXabo34Q9MVQw09XwyWKsxYblozqkXLVpvYyaSpB+6I9MEDSt2HvZhA== X-Received: by 2002:a1c:9ad0:: with SMTP id c199mr1800943wme.54.1601584026233; Thu, 01 Oct 2020 13:27:06 -0700 (PDT) Date: Thu, 1 Oct 2020 22:27:03 +0200 From: Petr Vorel To: Rich Felker Cc: linux-kernel@vger.kernel.org, musl@lists.openwall.com, linux-api@vger.kernel.org, libc-alpha@sourceware.org, Peter Korsgaard , Florian Weimer , Baruch Siach , "David S . Miller" , Michal Kubecek , Stephen Hemminger Message-ID: <20201001202703.GD24195@dell5510> References: <20201001195231.17226-1-petr.vorel@gmail.com> <20201001201108.GR17637@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201001201108.GR17637@brightrain.aerifal.cx> Subject: Re: [musl] [PATCH 1/1] uapi: Don't include in Hi Rich, > On Thu, Oct 01, 2020 at 09:52:31PM +0200, Petr Vorel wrote: > > + update code where needed (include in code which > > included only to get struct sysinfo or SI_LOAD_SHIFT). > > The reason is to avoid indirect include when using > > some network headers: or others [1] -> > > -> . > > This indirect include causes redefinition of struct sysinfo when > > included both and some of network headers: > > In file included from x86_64-buildroot-linux-musl/sysroot/usr/include/linux/kernel.h:5, > > from x86_64-buildroot-linux-musl/sysroot/usr/include/linux/netlink.h:5, > > from ../include/tst_netlink.h:14, > > from tst_crypto.c:13: > > x86_64-buildroot-linux-musl/sysroot/usr/include/linux/sysinfo.h:8:8: error: redefinition of ‘struct sysinfo’ > > struct sysinfo { > > ^~~~~~~ > > In file included from ../include/tst_safe_macros.h:15, > > from ../include/tst_test.h:93, > > from tst_crypto.c:11: > > x86_64-buildroot-linux-musl/sysroot/usr/include/sys/sysinfo.h:10:8: note: originally defined here > > [1] or , , , > > Suggested-by: Rich Felker > > Signed-off-by: Petr Vorel > > --- > > Hi, > > this looks to be long standing problem: python-psutil [2], iproute2 [3], > > even for glibc in the past [4] and it tried to be solved before [5]. > > This will require glibc fix after: > You can't do this; it breaks the existing contract with glibc. New > kernel headers can't force a glibc upgrade. Right, got that. > You just have to get rid > of use of elsewhere in the uapi headers. It was a > mistake that was ever separated out of > since it didn't (and couldn't) fix the contract that > exposes struct sysinfo (and that it's misnamed). But > it's no big deal. This can all be fixed without any breakage anywhere > just by not using it. Back to your original suggestion to move the alignment macros to a separate header. I was trying to avoid it not sure if introducing new header is acceptable, but we'll see. > Rich Kind regards, Petr