From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 9756 invoked from network); 11 Oct 2020 00:14:31 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 11 Oct 2020 00:14:31 -0000 Received: (qmail 26181 invoked by uid 550); 11 Oct 2020 00:14:29 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 26163 invoked from network); 11 Oct 2020 00:14:28 -0000 Date: Sat, 10 Oct 2020 20:14:16 -0400 From: Rich Felker To: musl@lists.openwall.com Message-ID: <20201011001416.GE17637@brightrain.aerifal.cx> References: <20201010185110.748-1-issam.e.maghni@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201010185110.748-1-issam.e.maghni@mailbox.org> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] [PATCH 1/2] configure: do not use obsolescent form of test -a|o On Sat, Oct 10, 2020 at 06:51:09PM +0000, Issam E. Maghni wrote: > > The XSI extensions specifying the -a and -o binary primaries and the '(' and > > ')' operators have been marked obsolescent. > https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html#tag_20_128_16 > > Signed-off-by: Issam E. Maghni Please keep commit messages to at most 76 columns, preferably less ala email conventions, so that git log is readable in 80, and avoid block quoting or other formatting that might not work well in all contexts it's displayed in. A description is also preferred to quoting in general, e.g. here: The -a and -o operators are obsolescent and not in baseline POSIX. Also no need for S-o-b. Otherwise the patch itself looks good. Thanks for catching this. Rich > --- > configure | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index 947adf41..a5231a0e 100755 > --- a/configure > +++ b/configure > @@ -204,7 +204,7 @@ fi > abs_builddir="$(pwd)" || fail "$0: cannot determine working directory" > abs_srcdir="$(cd $srcdir && pwd)" || fail "$0: invalid source directory $srcdir" > test "$abs_srcdir" = "$abs_builddir" && srcdir=. > -test "$srcdir" != "." -a -f Makefile -a ! -h Makefile && fail "$0: Makefile already exists in the working directory" > +test "$srcdir" != "." && test -f Makefile && test ! -h Makefile && fail "$0: Makefile already exists in the working directory" > > # > # Get a temp filename we can use > @@ -279,7 +279,7 @@ echo "$cc_family" > # > # Figure out toolchain wrapper to build > # > -if test "$wrapper" = auto -o "$wrapper" = detect ; then > +if test "$wrapper" = auto || test "$wrapper" = detect ; then > echo "#include " > "$tmpc" > echo "#if ! __GLIBC__" >> "$tmpc" > echo "#error no" >> "$tmpc" > @@ -468,7 +468,7 @@ tryflag CFLAGS_AUTO -pipe > # pointer is no longer needed for debugging. > # > if fnmatch '-g*|*\ -g*' "$CFLAGS_AUTO $CFLAGS" ; then : > -else > +else > tryflag CFLAGS_AUTO -fomit-frame-pointer > fi > > -- > 2.28.0