From: Rich Felker <dalias@libc.org>
To: Jouni Roivas <jouni.roivas@tuxera.com>
Cc: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] Skip writing first iovec if it's empty
Date: Mon, 12 Oct 2020 11:02:16 -0400 [thread overview]
Message-ID: <20201012150215.GH17637@brightrain.aerifal.cx> (raw)
In-Reply-To: <20201012125901.2629590-1-jouni.roivas@tuxera.com>
On Mon, Oct 12, 2020 at 03:59:01PM +0300, Jouni Roivas wrote:
> In case the first iovec is empty, skip writing it. Usually writing
> zero length iovec is no-op, but in case of certain special cases this
> causes the write to fail.
>
> This affects at least cgroups under sysfs, since it doesn't properly
> support writev with multiple iovec. For those kernel tends to handle
> them as simple as possible, passing each iovec separately. In case
> of zero length write into cgroups file causes kernel to return error.
> Thus if writing the first iovec fails for being zero length, it
> causes the whole write to fail even if writing the second iovec would
> succeed. This happens for example when doing unbuffered write with
> musl to a file under cgroups. Fix the issue here, since if kernel
> gets fixed for this specific case, it still doesn't get fixed for
> older kernels, nor any other possible similar case.
> ---
> src/stdio/__stdio_write.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/stdio/__stdio_write.c b/src/stdio/__stdio_write.c
> index d2d89475..eedce03a 100644
> --- a/src/stdio/__stdio_write.c
> +++ b/src/stdio/__stdio_write.c
> @@ -11,6 +11,10 @@ size_t __stdio_write(FILE *f, const unsigned char *buf, size_t len)
> size_t rem = iov[0].iov_len + iov[1].iov_len;
> int iovcnt = 2;
> ssize_t cnt;
> + if (iov[0].iov_len == 0) {
> + iov++;
> + iovcnt--;
> + }
> for (;;) {
> cnt = syscall(SYS_writev, f->fd, iov, iovcnt);
> if (cnt == rem) {
> --
> 2.25.1
I don't think this is sufficient to make writing procfs/sysfs files
via stdio work reliably; their interface is fundamentally incompatible
with flexibility of implementation in buffering. But it might be
preferable to do this still for other reasons. If we go forward with
this I think the commit message needs major rework so as not to be
implying that it makes the procfs/sysfs thing into a supported usage
case.
Note that commit e7eeeb9f2a4a358fb0bbed81e145ef5538ff60f0 did the
analog for __stdio_read in a way that's probably slightly better, but
that would need adaptation to work for the write case.
Rich
next prev parent reply other threads:[~2020-10-12 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 12:59 Jouni Roivas
2020-10-12 15:02 ` Rich Felker [this message]
2020-10-12 16:30 ` Jouni Roivas
2020-10-12 16:43 ` [musl] [PATCH v2] avoid writing two iov in __stdio_write backend when not needed Jouni Roivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012150215.GH17637@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=jouni.roivas@tuxera.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).