From: Szabolcs Nagy <nsz@port70.net>
To: Alexey Izbyshev <izbyshev@ispras.ru>
Cc: musl@lists.openwall.com
Subject: Re: [musl] Why is setrlimit() considered to have per-thread effect?
Date: Thu, 15 Oct 2020 10:50:24 +0200 [thread overview]
Message-ID: <20201015085024.GR2947641@port70.net> (raw)
In-Reply-To: <948f6fc6f3458f18152c0f8b505beec0@ispras.ru>
* Alexey Izbyshev <izbyshev@ispras.ru> [2020-10-15 08:01:00 +0300]:
> Commit 544ee752cd[1] claims that setrlimit() is per-thread on Linux,
> similarly to setxid() calls, so it should be called via __synccall(). But
> this appears to be wrong: the kernel code operates on tsk->signal[2], which
> is a per-thread-group structure. Glibc doesn't call setrlimit() for each
> thread either. Am I missing something?
note that prlimit does not have synccall in
musl: the kernel implemented the per process
rlimit setting when prlimit was added.
(i think this is linux commit
1c1e618ddd15f69fd87ccea596769f78c8065504 )
but older kernels don't have that.
>
> Tangentially, setgroups() is not called via __synccall(), though it does
> have per-thread effect. Is this intentional?
that may be a bug, but it's not a posix api
so not a conformance issue, but a linux issue:
if other linux libcs don't do synccall then
that's the defacto interface contract.
>
> Alexey
>
> [1] https://git.musl-libc.org/cgit/musl/commit/?id=544ee752cd38febfa3aa3798b4dfb6fabd13846b
> [2] https://elixir.bootlin.com/linux/v5.9/source/kernel/sys.c#L1566
next prev parent reply other threads:[~2020-10-15 8:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 5:01 Alexey Izbyshev
2020-10-15 8:50 ` Szabolcs Nagy [this message]
2020-10-15 15:49 ` Rich Felker
2020-10-15 16:13 ` Alexey Izbyshev
2020-10-15 17:13 ` Rich Felker
2020-10-15 18:26 ` Alexey Izbyshev
2020-10-15 20:03 ` Rich Felker
2020-10-15 15:50 ` Alexey Izbyshev
2020-10-15 20:05 ` Rich Felker
2020-10-15 15:43 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015085024.GR2947641@port70.net \
--to=nsz@port70.net \
--cc=izbyshev@ispras.ru \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).