From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [musl] [PATCH v2] MT fork
Date: Sat, 31 Oct 2020 10:47:36 -0400 [thread overview]
Message-ID: <20201031144735.GJ534@brightrain.aerifal.cx> (raw)
In-Reply-To: <20201031092204.527aac8e@vostro.wlan>
On Sat, Oct 31, 2020 at 09:22:04AM +0200, Timo Teras wrote:
> Hi
>
> On Fri, 30 Oct 2020 15:31:54 -0600
> Ariadne Conill <ariadne@dereferenced.org> wrote:
>
> > On Friday, October 30, 2020 12:57:17 PM MDT Rich Felker wrote:
> > > There was a regression in musl too, I think. With
> > > 27b2fc9d6db956359727a66c262f1e69995660aa you should be able to
> > > re-enable parallel mark. If you get a chance to test, let us know if
> > > it works for you.
> >
> > I have pushed current musl git plus the MT fork patch to Alpine edge
> > as Alpine musl 1.2.2_pre0, and reenabling parallel mark has worked
> > fine.
> >
> > It would be nice to have a musl 1.2.2 release that I can use for the
> > source tarball instead of a git snapshot, but this will do for now.
>
> And now firefox is utterly broken. Though seems to be not related to MT
> fork patch.
>
> Bisected it down to commit b8b729bd22c28c9116c2fce65dce207a35299c26
> "fix missing O_LARGEFILE values on x86_64, x32, and mips64"
>
> I think this breaks the seccomp because now e.g. fopen() calls has this
> bit set for the syscall and seccomp does not like it.
>
> Wondering whether to fix firefox seccomp ignore this bit, or if this
> commit needs reconsideration?
Firefox needs to be fixed. A seccomp filter error is *always* the
filter being wrong.
Further, there should be a real audit of these filters (I'm willing to
do it myself if someone can dig up the code I need to look at) to
prevent this kind of thing preemptively. Any reasonable review would
have shown this code was wrong if blocking the bit was specific to
x86_64 and a few other archs, and if it's not specific, all the other
archs were already broken. I'm pretty sure we'll find a lot of other
issues that need to be fixed, some of them probably breaking
less-popular archs right now.
Rich
next prev parent reply other threads:[~2020-10-31 14:47 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 0:50 [musl] Status report and " Rich Felker
2020-10-26 0:59 ` Rich Felker
2020-10-26 3:29 ` Rich Felker
2020-10-26 18:44 ` Érico Nogueira
2020-10-26 19:52 ` Rich Felker
2020-10-26 20:11 ` Érico Nogueira
2020-10-27 21:17 ` Rich Felker
2020-10-28 18:56 ` [musl] [PATCH v2] " Rich Felker
2020-10-28 23:06 ` Milan P. Stanić
2020-10-29 16:13 ` Szabolcs Nagy
2020-10-29 16:20 ` Rich Felker
2020-10-29 20:55 ` Milan P. Stanić
2020-10-29 22:21 ` Szabolcs Nagy
2020-10-29 23:00 ` Milan P. Stanić
2020-10-29 23:27 ` Rich Felker
2020-10-30 0:13 ` Rich Felker
2020-10-30 7:47 ` Milan P. Stanić
2020-10-30 18:52 ` Milan P. Stanić
2020-10-30 18:57 ` Rich Felker
2020-10-30 21:31 ` Ariadne Conill
2020-10-31 3:31 ` Rich Felker
2020-11-06 3:36 ` Rich Felker
2020-11-08 16:12 ` Szabolcs Nagy
2020-11-09 17:07 ` Rich Felker
2020-11-09 18:01 ` Érico Nogueira
2020-11-09 18:44 ` Rich Felker
2020-11-09 18:54 ` Érico Nogueira
2020-11-09 21:59 ` Szabolcs Nagy
2020-11-09 22:23 ` Rich Felker
2020-11-11 0:52 ` Rich Felker
2020-11-11 6:35 ` Alexey Izbyshev
2020-11-11 11:25 ` Szabolcs Nagy
2020-11-11 14:56 ` Rich Felker
2020-11-11 16:35 ` Rich Felker
2020-10-31 7:22 ` Timo Teras
2020-10-31 13:29 ` Szabolcs Nagy
2020-10-31 13:35 ` Timo Teras
2020-10-31 14:41 ` Ariadne Conill
2020-10-31 14:49 ` Rich Felker
2020-10-31 14:48 ` Rich Felker
2020-10-31 14:47 ` Rich Felker [this message]
2020-10-29 23:32 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201031144735.GJ534@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).