mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Wolf <wolf@wolfsden.cz>
To: musl@lists.openwall.com
Subject: Re: [musl] swprintf possible bug
Date: Sun, 1 Nov 2020 21:48:32 +0100	[thread overview]
Message-ID: <20201101204832.zk7xmsdazrw7tz52@wolfsden.cz> (raw)
In-Reply-To: <C6S7DCPAVDGM.3MUY7E2KQQCMO@mussels>

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

On 2020-11-01 17:17:49 -0300, Érico Nogueira wrote:
> For what it's worth, if this is a bug, it would seem to be in how musl
> decides when to print characters (not the formatting functions
> themselves), since the below program doesn't print anything:
> 
> #include <wchar.h>
> #include <stdio.h>
> 
> int main() {
>   fputws(L"[Привет Василий]\n", stdout);
>   // I don't know if I'm accessing a wchar_t appropriately here
>   fputwc(L"[Привет Василий]\n"[3], stdout);
>   return 0;
> }
> 
> I tried tracing the execution from fputws, and not printing anything
> seems to be caused by the return value of wcsrtombs().

That seems to be on the right track, since when you actually check the
return code from fputws:

	#include <wchar.h>
	#include <stdio.h>

	int main(void) {
		if (fputws(L"[Привет Василий]\n", stdout) == -1) {
			perror("fputws");
		}
	}

you get this:

	# ./a
	fputws: Illegal byte sequence

I think it is caused by C (or POSIX) locale being default on entry to
main, so you need to actually activate the system locale by calling
setlocale(LC_ALL, "").

Indeed, if you modify the program to:

	#include <wchar.h>
	#include <stdio.h>
	#include <locale.h>

	int main(void) {
		setlocale(LC_ALL, "");
		if (fputws(L"[Привет Василий]\n", stdout) == -1) {
			perror("fputws");
		}
	}

It starts to work:

	# ./a
	[Привет Василий]


W.

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2020-11-01 20:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-01 19:06 Alexander Vitiuk
2020-11-01 20:17 ` Érico Nogueira
2020-11-01 20:40   ` Szabolcs Nagy
2020-11-01 20:48     ` Érico Nogueira
2020-11-01 21:05       ` Rich Felker
2020-11-01 20:48   ` Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201101204832.zk7xmsdazrw7tz52@wolfsden.cz \
    --to=wolf@wolfsden.cz \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).