mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Wolf <wolf@wolfsden.cz>
To: musl@lists.openwall.com
Subject: Re: [musl] Authorship/attribution and stalled patches
Date: Mon, 2 Nov 2020 21:45:45 +0100	[thread overview]
Message-ID: <20201102204545.lwjv3oulrv54brs6@wolfsden.cz> (raw)
In-Reply-To: <20201102194557.GU534@brightrain.aerifal.cx>

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

Hello,

On 2020-11-02 14:45:58 -0500, Rich Felker wrote:
> This would be a major regression in maintainership quality. It
> introduces versions that don't work/have new bugs that would not
> otherwise be in the history, making it harder to bisect, harder for
> patches to commute (and be backported etc.), harder to read and
> understand, etc. The intent of the history is to be a history is
> approved changes, with clearly documented motivations for each.

My opinion on this is that for

1. Commit message only changes

Just rewrite the commit message and add note at the bottom along the
lines that "Commit message by Rich" or something like that. And leave
original author.

2. Changes in the patch itself

This I think calls for common sense approach, based on how large the
changes are. Same approach in as 1., in case of small changes add
something like "Slightly modified by Rich", in case of large(r) rewrite
"Based on patch by AUTHOR".



If the end goal is to merge those stale patches, I think this is best
that can be done.

W.

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2020-11-02 20:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02  1:16 Rich Felker
2020-11-02  1:30 ` Rich Felker
2020-11-02 19:40 ` Markus Wichmann
2020-11-02 19:45   ` Rich Felker
2020-11-02 20:45     ` Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102204545.lwjv3oulrv54brs6@wolfsden.cz \
    --to=wolf@wolfsden.cz \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).