From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 11450 invoked from network); 7 Nov 2020 06:52:26 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 7 Nov 2020 06:52:26 -0000 Received: (qmail 10042 invoked by uid 550); 7 Nov 2020 06:52:21 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 9975 invoked from network); 7 Nov 2020 06:52:20 -0000 X-Virus-Scanned: Debian amavisd-new at disroot.org From: =?UTF-8?q?=C3=89rico=20Nogueira?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1604731928; bh=5J4KbgaFgWLSxCgb1Z928WwLkJPEzBZ+F03IyalGIbU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GdQaaetavpihNG5xS1jxILv14PYu0i7Zm47MFWKIkHpvC4JSXf8KkCh9yJZBTdgil dAeFcc1zRZN0vbKb20n/3QYXe9V1/WT5H1NHEbT7pR8XQ2HGPRabzcL9+w9wpYtk6F wLgXg8T6bBsXbXifPJRqRwOhbp/hDGSusJEy5Fvp420Bx718aD6Vo6D5zW5dcANbXN c3gplmPpFyOieVX3siOUPzahTY469K1mEBhH4NhsZ0i7KS61jZSQn7zem/Suq+vfyA 3vB5zdcEN0v9J8ALV6vfBPzM422i6E6hc9Wvjv879KteH7DbPcWT+U2eK3y2f4zy4+ 6MQ1Z4zOGxeEw== To: musl@lists.openwall.com Cc: =?UTF-8?q?=C3=89rico=20Rolim?= Date: Sat, 7 Nov 2020 03:51:43 -0300 Message-Id: <20201107065143.10191-2-ericonr@disroot.org> In-Reply-To: <20201107065143.10191-1-ericonr@disroot.org> References: <20201107065143.10191-1-ericonr@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [musl] [PATCH 2/2] sbsiglist: fix typo when checking cli args. From: Érico Rolim type_str was being checked twice, and owner_guid_str wasn't checked at all. This lead to a possible segfault when only --owner was missing from the command line arguments. --- src/sbsiglist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sbsiglist.c b/src/sbsiglist.c index 7d396fa..aada63a 100644 --- a/src/sbsiglist.c +++ b/src/sbsiglist.c @@ -241,7 +241,7 @@ int main(int argc, char **argv) return EXIT_FAILURE; } - if (!type_str) { + if (!owner_guid_str) { fprintf(stderr, "No owner specified\n"); usage(); return EXIT_FAILURE; -- 2.29.2