mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [musl] realpath without procfs -- should be ready for inclusion
Date: Sun, 22 Nov 2020 22:34:01 -0500	[thread overview]
Message-ID: <20201123033400.GT534@brightrain.aerifal.cx> (raw)
In-Reply-To: <C7ABG2VZCDZZ.8MJR3SJ8HXLA@mussels>

On Mon, Nov 23, 2020 at 12:17:27AM -0300, Érico Nogueira wrote:
> On Sun Nov 22, 2020 at 11:03 PM -03, Alexey Izbyshev wrote:
> > On 2020-11-23 01:56, Rich Felker wrote:
> > > I originally considered keeping the procfs based version and only
> > > using the new one as a fallback, but I discovered there are cases
> > > (involving chroot, namespaces, etc.) where the answer from procfs is
> > > wrong and validating it requires basically the same procedure as
> > > implementing it manually (walking and performing readlink on each path
> > > component).
> > > 
> > Pity that the simple and fast procfs-based implementation goes away. Do
> > you have any specific example of a wrong answer from procfs at hand, or
> > at least a more specific direction to look at than just
> > "chroot/namespaces"?
> 
> bubblewrap (when driven by Flatpak) is one such software. Void carries
> a patch [1] with NetBSD's realpath impl to work around this. Without it,
> launching flatpak applications sometimes didn't work at all.
> 
> - [1] https://github.com/void-linux/void-packages/blob/da86d30391e2b3535e8f9dfae452d2b362887e41/srcpkgs/bubblewrap/patches/realpath-workaround.patch

FWIW this seems to be a reason for needing the real implementation
like proposed, but not a reason for getting rid of the proc-based code
path. The reasons for that I mostly covered in my reply.

Rich

  reply	other threads:[~2020-11-23  3:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-22 22:56 Rich Felker
2020-11-23  2:03 ` Alexey Izbyshev
2020-11-23  3:17   ` Érico Nogueira
2020-11-23  3:34     ` Rich Felker [this message]
2020-11-23  3:19   ` Rich Felker
2020-11-23 18:56     ` Rich Felker
2020-11-23 20:53       ` Rich Felker
2020-11-24  3:39         ` Alexey Izbyshev
2020-11-24  4:26           ` Rich Felker
2020-11-24  5:13             ` Alexey Izbyshev
2020-11-24  6:30               ` Rich Felker
2020-11-24  9:21                 ` Alexey Izbyshev
2020-11-24 14:35                   ` Rich Felker
2020-11-24 20:17                     ` Rich Felker
2020-11-25 15:02                   ` Rich Felker
2020-11-25 19:40                     ` Alexey Izbyshev
2020-11-24 20:31             ` Rich Felker
2020-11-25  5:40               ` Alexey Izbyshev
2020-11-25 15:03                 ` Rich Felker
2020-11-24  3:41     ` Alexey Izbyshev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201123033400.GT534@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).